-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHERRY-PICK] [Release/202311] UnitTestFrameworkPkg: Fix Google Test components with multiple files #891
Merged
Flickdm
merged 2 commits into
release/202311
from
cherrypick/release/202311/unittestframeworkpkg/wholearchive
Jun 6, 2024
Merged
[CHERRY-PICK] [Release/202311] UnitTestFrameworkPkg: Fix Google Test components with multiple files #891
Flickdm
merged 2 commits into
release/202311
from
cherrypick/release/202311/unittestframeworkpkg/wholearchive
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flickdm
added
impact:non-functional
Does not have a functional impact
impact:testing
Affects testing
type:bug
Something isn't working
labels
Jun 5, 2024
apop5
approved these changes
Jun 6, 2024
Javagedes
approved these changes
Jun 6, 2024
VivianNK
reviewed
Jun 6, 2024
Flickdm
force-pushed
the
cherrypick/release/202311/unittestframeworkpkg/wholearchive
branch
from
June 6, 2024 20:14
bbbd796
to
5f59950
Compare
VivianNK
approved these changes
Jun 6, 2024
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4610 Google Test hides test registration in global constructors on global objects. Global constructors are traditionally implemented by placing references to the global constructor's symbol in special sections (traditionally named .ctors or .init_array). These sections are not explicitly referenced by the linker, and libc only looks at special start and end symbols (and calls them). This works fine if you're linking a program manually using gcc a.o b.o c.o -o test_suite but fails miserably when using static libraries (such as what EDK2 does), because traditional static archive symbol resolution rules don't allow for object files to be pulled in to the link if there isn't an undefined symbol reference to that .o elsewhere. Fix it by passing --whole-archive (GCC) and /WHOLEARCHIVE (MSVC). These options force the linker to pull in the entire static library, thus including previously-unreferenced constructors and making sure multi-file gtest EDK2 components work. Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Michael Kubacki <mikuback@linux.microsoft.com> Cc: Sean Brogan <sean.brogan@microsoft.com> Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com> Reviewed-by: Cc: Michael D Kinney <michael.d.kinney@intel.com>
> This is a cherry-pick to keep the -D GOOGLETEST_HOST_UNIT_TEST_BUILD=1 Cmocka is able to test STATIC functions by including the C file in the test file. However, in many scenarios, GoogleTest files cannot do this as the C++ compiler has stricter rules than the C compiler. This patch updates the UnitTestFrameworkPkgHost.dsc.in to add a new build flag GOOGLETEST_HOST_UNIT_TEST_BUILD for HOST_APPLICATIONS only. Base.h is then updated to undef STATIC if this flag is set. This allows for STATIC functions to be tested in GoogleTest. There is less danger of symbol collision here, because HOST_APPLICATIONS are running with the least amount of dependencies possible. This still allows for interfaces tests (where a Library Class is tested, not an instance, so the library is linked in to the test instead of compiled) as the library in this case will not be compiled as a HOST_APPLICATION and so the STATIC functions will remain STATIC.
Flickdm
force-pushed
the
cherrypick/release/202311/unittestframeworkpkg/wholearchive
branch
from
June 6, 2024 21:17
5f59950
to
bf1d74e
Compare
Flickdm
deleted the
cherrypick/release/202311/unittestframeworkpkg/wholearchive
branch
June 6, 2024 21:31
Flickdm
added a commit
that referenced
this pull request
Jun 6, 2024
REF: #891 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4610 Google Test hides test registration in global constructors on global objects. Global constructors are traditionally implemented by placing references to the global constructor's symbol in special sections (traditionally named .ctors or .init_array). These sections are not explicitly referenced by the linker, and libc only looks at special start and end symbols (and calls them). This works fine if you're linking a program manually using gcc a.o b.o c.o -o test_suite but fails miserably when using static libraries (such as what EDK2 does), because traditional static archive symbol resolution rules don't allow for object files to be pulled in to the link if there isn't an undefined symbol reference to that .o elsewhere. Fix it by passing --whole-archive (GCC) and /WHOLEARCHIVE (MSVC). These options force the linker to pull in the entire static library, thus including previously-unreferenced constructors and making sure multi-file gtest EDK2 components work. Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Michael Kubacki <mikuback@linux.microsoft.com> Cc: Sean Brogan <sean.brogan@microsoft.com> Reviewed-by: Cc: Michael D Kinney <michael.d.kinney@intel.com> This corrects an issue with MSVC where unit tests are not being linked correctly - thus creating unit tests with zero tests For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [x] Includes tests? - This will cause unit tests to actually run with MSVC - [ ] Includes documentation? Local builds with Host Based Unit Tests N/A --------- Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com> Co-authored-by: Pedro Falcato <pedro.falcato@gmail.com> Co-authored-by: Oliver Smith-Denny <osde@microsoft.com>
5 tasks
Flickdm
added a commit
that referenced
this pull request
Jun 6, 2024
REF: #891 - Dropping GOOGLETEST_HOST_UNIT_BUILD option as release/202302 does not have any expectation to support it. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4610 Google Test hides test registration in global constructors on global objects. Global constructors are traditionally implemented by placing references to the global constructor's symbol in special sections (traditionally named .ctors or .init_array). These sections are not explicitly referenced by the linker, and libc only looks at special start and end symbols (and calls them). This works fine if you're linking a program manually using gcc a.o b.o c.o -o test_suite but fails miserably when using static libraries (such as what EDK2 does), because traditional static archive symbol resolution rules don't allow for object files to be pulled in to the link if there isn't an undefined symbol reference to that .o elsewhere. Fix it by passing --whole-archive (GCC) and /WHOLEARCHIVE (MSVC). These options force the linker to pull in the entire static library, thus including previously-unreferenced constructors and making sure multi-file gtest EDK2 components work. Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Michael Kubacki <mikuback@linux.microsoft.com> Cc: Sean Brogan <sean.brogan@microsoft.com> Reviewed-by: Cc: Michael D Kinney <michael.d.kinney@intel.com> This corrects an issue with MSVC where unit tests are not being linked correctly - thus creating unit tests with zero tests For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [x] Includes tests? - This will cause unit tests to actually run with MSVC - [ ] Includes documentation? Local builds with Host Based Unit Tests N/A --------- Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com> Co-authored-by: Pedro Falcato <pedro.falcato@gmail.com> Co-authored-by: Oliver Smith-Denny <osde@microsoft.com>
Flickdm
added a commit
that referenced
this pull request
Jun 6, 2024
REF: #891 - Dropping GOOGLETEST_HOST_UNIT_BUILD option as release/202302 does not have any expectation to support it. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4610 Google Test hides test registration in global constructors on global objects. Global constructors are traditionally implemented by placing references to the global constructor's symbol in special sections (traditionally named .ctors or .init_array). These sections are not explicitly referenced by the linker, and libc only looks at special start and end symbols (and calls them). This works fine if you're linking a program manually using gcc a.o b.o c.o -o test_suite but fails miserably when using static libraries (such as what EDK2 does), because traditional static archive symbol resolution rules don't allow for object files to be pulled in to the link if there isn't an undefined symbol reference to that .o elsewhere. Fix it by passing --whole-archive (GCC) and /WHOLEARCHIVE (MSVC). These options force the linker to pull in the entire static library, thus including previously-unreferenced constructors and making sure multi-file gtest EDK2 components work. Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Michael Kubacki <mikuback@linux.microsoft.com> Cc: Sean Brogan <sean.brogan@microsoft.com> Reviewed-by: Cc: Michael D Kinney <michael.d.kinney@intel.com> This corrects an issue with MSVC where unit tests are not being linked correctly - thus creating unit tests with zero tests For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [x] Includes tests? - This will cause unit tests to actually run with MSVC - [ ] Includes documentation? Local builds with Host Based Unit Tests N/A --------- Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com> Co-authored-by: Pedro Falcato <pedro.falcato@gmail.com> Co-authored-by: Oliver Smith-Denny <osde@microsoft.com>
Flickdm
added a commit
that referenced
this pull request
Jun 7, 2024
…components with multiple files (#893) # Preface REF: #891 - Dropping GOOGLETEST_HOST_UNIT_BUILD option as release/202302 does not have any expectation to support it. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4610 Google Test hides test registration in global constructors on global objects. Global constructors are traditionally implemented by placing references to the global constructor's symbol in special sections (traditionally named .ctors or .init_array). These sections are not explicitly referenced by the linker, and libc only looks at special start and end symbols (and calls them). This works fine if you're linking a program manually using gcc a.o b.o c.o -o test_suite but fails miserably when using static libraries (such as what EDK2 does), because traditional static archive symbol resolution rules don't allow for object files to be pulled in to the link if there isn't an undefined symbol reference to that .o elsewhere. Fix it by passing --whole-archive (GCC) and /WHOLEARCHIVE (MSVC). These options force the linker to pull in the entire static library, thus including previously-unreferenced constructors and making sure multi-file gtest EDK2 components work. Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Michael Kubacki <mikuback@linux.microsoft.com> Cc: Sean Brogan <sean.brogan@microsoft.com> Reviewed-by: Cc: Michael D Kinney <michael.d.kinney@intel.com> ## Description This corrects an issue with MSVC where unit tests are not being linked correctly - thus creating unit tests with zero tests For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [x] Includes tests? - This will cause unit tests to actually run with MSVC - [ ] Includes documentation? ## How This Was Tested Local builds with Host Based Unit Tests ## Integration Instructions N/A Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com> Co-authored-by: Pedro Falcato <pedro.falcato@gmail.com> Co-authored-by: Oliver Smith-Denny <osde@microsoft.com>
apop5
added a commit
to apop5/mu_feature_config
that referenced
this pull request
Jun 20, 2024
Unit tests started failing due to compilation errors. This stemmed from a bug fixed in microsoft/mu_basecore#891. Checking previous pipelines, these tests were not compiled due to the above mentioned bug.
5 tasks
apop5
added a commit
to microsoft/mu_feature_config
that referenced
this pull request
Jun 20, 2024
…#369) ## Description Unit tests started failing due to compilation errors. This stemmed from a bug fixed in microsoft/mu_basecore#891. Once this bug was fixed, the unit tests starting to be compiled which blocked pipelines. Checking previous pipelines, these tests were not compiled due to the above mentioned bug. Once the fix was cherry picked back into basecore 202302, it started blocking the pipelines. For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Ran CI locally and resolved issues. ## Integration Instructions N/A
apop5
added a commit
to apop5/mu_plus
that referenced
this pull request
Jun 20, 2024
Unit tests started failing due to compilation errors. This stemmed from a bug fixed in microsoft/mu_basecore#891. Once this bug was fixed, the unit tests starting to be compiled which blocked pipelines.
5 tasks
apop5
added a commit
to microsoft/mu_plus
that referenced
this pull request
Jun 20, 2024
## Description Unit tests started failing due to compilation errors. This stemmed from a bug fixed in microsoft/mu_basecore#891. Once this bug was fixed, the unit tests starting to be compiled which blocked pipelines. For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Ran Local CI to verify unit tests change. ## Integration Instructions N/A
apop5
added a commit
to apop5/mu_feature_ipmi
that referenced
this pull request
Jun 21, 2024
…est compilation errors. Unit tests started failing due to compilation errors. This stemmed from a bug fixed in microsoft/mu_basecore#891. Once this bug was fixed, the unit tests starting to be compiled which blocked pipelines.
apop5
added a commit
to apop5/mu_feature_ipmi
that referenced
this pull request
Jun 21, 2024
…est compilation errors. Unit tests started failing due to compilation errors. This stemmed from a bug fixed in microsoft/mu_basecore#891. Once this bug was fixed, the unit tests starting to be compiled which blocked pipelines.
apop5
added a commit
to microsoft/mu_feature_ipmi
that referenced
this pull request
Jun 21, 2024
#239) ## Description Unit tests started failing due to compilation errors. This stemmed from a bug fixed in microsoft/mu_basecore#891. Once this bug was fixed, the unit tests starting to be compiled which blocked pipelines. For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Local CI. ## Integration Instructions N/A
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Jun 28, 2024
Introduces 12 new commits in [MU_BASECORE](https://github.com/microsoft/mu_basecore.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_basecore/commit/3a55a400815a25a25a9aa657e99c95edf750188e">3a55a4</a> [CHERRY-PICK] [Release/202311] UnitTestFrameworkPkg: Fix Google Test components with multiple files (<a href="https://github.com/microsoft/mu_basecore/pull/891">#891</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/1475a86d1603236e0c1da7d22d37021c8dc7bf91">1475a8</a> [CHERRY-PICK] [RELEASE/202311] Pulling PixieFail changes from EDK2 for CVE-2023-45237 and CVE-2023-45236 (<a href="https://github.com/microsoft/mu_basecore/pull/897">#897</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/23c33e211ef80511d161d3804ffe5ff4b00c652d">23c33e</a> BaseTools/Plugin/HostBasedUnitTestRunner: Fix invalid escape in HostBasedUnitTest.py (<a href="https://github.com/microsoft/mu_basecore/pull/899">#899</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/f598b780f7ae52d90422750214e2450fa24d4ded">f598b7</a> [CHERRY-PICK] UefiCpuPkg:fix issue when splitting paging entry (<a href="https://github.com/microsoft/mu_basecore/pull/909">#909</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/bbbff00dc39a67dc1e44aa0ce392d460b12f66b9">bbbff0</a> Change CpuDeadLoops to panic calls in PiSmmCpuDxeSmm.c (<a href="https://github.com/microsoft/mu_basecore/pull/892">#892</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/3ab77179e0d08269b155392c44e2f14724114e4e">3ab771</a> Added mock functions for UefiBootServicesTableLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/87b10e679399232d60fefdd6515812bd74571b6d">87b10e</a> Added mock functions for PciExpressLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/5a22ca63d43d7fa162a3adcfbc8d7eb3ffff3c60">5a22ca</a> Added mock functions for TimerLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/86dc06813bc2e1bbd59f06f52b3c97fb722718c0">86dc06</a> pip: update edk2-pytool-library requirement from ~=0.21.6 to ~=0.21.7 (<a href="https://github.com/microsoft/mu_basecore/pull/906">#906</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/e6d01390794aa0505d0659bc484f4d2fdba1e5d4">e6d013</a> pip: update edk2-pytool-extensions requirement from ~=0.27.5 to ~=0.27.6 (<a href="https://github.com/microsoft/mu_basecore/pull/907">#907</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/f9c86cda20d912e2ae6cce5e6daeae01ed6e8b52">f9c86c</a> pip: update edk2-pytool-library requirement from ~=0.21.7 to ~=0.21.8 (<a href="https://github.com/microsoft/mu_basecore/pull/966">#966</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/884e654b29d3611f976d5b9629ae9af920532dd3">884e65</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_basecore/pull/982">#982</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <mubot@microsoft.com>
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Jul 13, 2024
Introduces 17 new commits in [MU_BASECORE](https://github.com/microsoft/mu_basecore.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_basecore/commit/3a55a400815a25a25a9aa657e99c95edf750188e">3a55a4</a> [CHERRY-PICK] [Release/202311] UnitTestFrameworkPkg: Fix Google Test components with multiple files (<a href="https://github.com/microsoft/mu_basecore/pull/891">#891</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/1475a86d1603236e0c1da7d22d37021c8dc7bf91">1475a8</a> [CHERRY-PICK] [RELEASE/202311] Pulling PixieFail changes from EDK2 for CVE-2023-45237 and CVE-2023-45236 (<a href="https://github.com/microsoft/mu_basecore/pull/897">#897</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/23c33e211ef80511d161d3804ffe5ff4b00c652d">23c33e</a> BaseTools/Plugin/HostBasedUnitTestRunner: Fix invalid escape in HostBasedUnitTest.py (<a href="https://github.com/microsoft/mu_basecore/pull/899">#899</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/f598b780f7ae52d90422750214e2450fa24d4ded">f598b7</a> [CHERRY-PICK] UefiCpuPkg:fix issue when splitting paging entry (<a href="https://github.com/microsoft/mu_basecore/pull/909">#909</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/bbbff00dc39a67dc1e44aa0ce392d460b12f66b9">bbbff0</a> Change CpuDeadLoops to panic calls in PiSmmCpuDxeSmm.c (<a href="https://github.com/microsoft/mu_basecore/pull/892">#892</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/3ab77179e0d08269b155392c44e2f14724114e4e">3ab771</a> Added mock functions for UefiBootServicesTableLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/87b10e679399232d60fefdd6515812bd74571b6d">87b10e</a> Added mock functions for PciExpressLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/5a22ca63d43d7fa162a3adcfbc8d7eb3ffff3c60">5a22ca</a> Added mock functions for TimerLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/86dc06813bc2e1bbd59f06f52b3c97fb722718c0">86dc06</a> pip: update edk2-pytool-library requirement from ~=0.21.6 to ~=0.21.7 (<a href="https://github.com/microsoft/mu_basecore/pull/906">#906</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/e6d01390794aa0505d0659bc484f4d2fdba1e5d4">e6d013</a> pip: update edk2-pytool-extensions requirement from ~=0.27.5 to ~=0.27.6 (<a href="https://github.com/microsoft/mu_basecore/pull/907">#907</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/f9c86cda20d912e2ae6cce5e6daeae01ed6e8b52">f9c86c</a> pip: update edk2-pytool-library requirement from ~=0.21.7 to ~=0.21.8 (<a href="https://github.com/microsoft/mu_basecore/pull/966">#966</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/884e654b29d3611f976d5b9629ae9af920532dd3">884e65</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_basecore/pull/982">#982</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/fd8a09795aa2ea2a091906efb92124eb85d49e05">fd8a09</a> Host Based Unit Test updates (<a href="https://github.com/microsoft/mu_basecore/pull/837">#837</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/307dc02e66899fd9be316a2143783b261375b884">307dc0</a> GitHub Action: Bump robinraju/release-downloader from 1.10 to 1.11 (<a href="https://github.com/microsoft/mu_basecore/pull/1016">#1016</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/57770989fcac90b6e4046f5cd9a692afea1f318f">577709</a> pip: update edk2-pytool-extensions requirement from ~=0.27.6 to ~=0.27.8 (<a href="https://github.com/microsoft/mu_basecore/pull/1028">#1028</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/7cf3382ebaf5b5b5a2487d7d13e910c1c7dac233">7cf338</a> pip: update edk2-pytool-extensions requirement from ~=0.27.8 to ~=0.27.9 (<a href="https://github.com/microsoft/mu_basecore/pull/1033">#1033</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/90adf2bc49197314f6d8b2bb40d63d4c5c503065">90adf2</a> BaseTools/Plugin/RustEnvironmentCheck: Use pytools Rust helpers (<a href="https://github.com/microsoft/mu_basecore/pull/1037">#1037</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <mubot@microsoft.com>
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Jul 14, 2024
Introduces 18 new commits in [MU_BASECORE](https://github.com/microsoft/mu_basecore.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_basecore/commit/3a55a400815a25a25a9aa657e99c95edf750188e">3a55a4</a> [CHERRY-PICK] [Release/202311] UnitTestFrameworkPkg: Fix Google Test components with multiple files (<a href="https://github.com/microsoft/mu_basecore/pull/891">#891</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/1475a86d1603236e0c1da7d22d37021c8dc7bf91">1475a8</a> [CHERRY-PICK] [RELEASE/202311] Pulling PixieFail changes from EDK2 for CVE-2023-45237 and CVE-2023-45236 (<a href="https://github.com/microsoft/mu_basecore/pull/897">#897</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/23c33e211ef80511d161d3804ffe5ff4b00c652d">23c33e</a> BaseTools/Plugin/HostBasedUnitTestRunner: Fix invalid escape in HostBasedUnitTest.py (<a href="https://github.com/microsoft/mu_basecore/pull/899">#899</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/f598b780f7ae52d90422750214e2450fa24d4ded">f598b7</a> [CHERRY-PICK] UefiCpuPkg:fix issue when splitting paging entry (<a href="https://github.com/microsoft/mu_basecore/pull/909">#909</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/bbbff00dc39a67dc1e44aa0ce392d460b12f66b9">bbbff0</a> Change CpuDeadLoops to panic calls in PiSmmCpuDxeSmm.c (<a href="https://github.com/microsoft/mu_basecore/pull/892">#892</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/3ab77179e0d08269b155392c44e2f14724114e4e">3ab771</a> Added mock functions for UefiBootServicesTableLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/87b10e679399232d60fefdd6515812bd74571b6d">87b10e</a> Added mock functions for PciExpressLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/5a22ca63d43d7fa162a3adcfbc8d7eb3ffff3c60">5a22ca</a> Added mock functions for TimerLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/86dc06813bc2e1bbd59f06f52b3c97fb722718c0">86dc06</a> pip: update edk2-pytool-library requirement from ~=0.21.6 to ~=0.21.7 (<a href="https://github.com/microsoft/mu_basecore/pull/906">#906</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/e6d01390794aa0505d0659bc484f4d2fdba1e5d4">e6d013</a> pip: update edk2-pytool-extensions requirement from ~=0.27.5 to ~=0.27.6 (<a href="https://github.com/microsoft/mu_basecore/pull/907">#907</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/f9c86cda20d912e2ae6cce5e6daeae01ed6e8b52">f9c86c</a> pip: update edk2-pytool-library requirement from ~=0.21.7 to ~=0.21.8 (<a href="https://github.com/microsoft/mu_basecore/pull/966">#966</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/884e654b29d3611f976d5b9629ae9af920532dd3">884e65</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_basecore/pull/982">#982</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/fd8a09795aa2ea2a091906efb92124eb85d49e05">fd8a09</a> Host Based Unit Test updates (<a href="https://github.com/microsoft/mu_basecore/pull/837">#837</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/307dc02e66899fd9be316a2143783b261375b884">307dc0</a> GitHub Action: Bump robinraju/release-downloader from 1.10 to 1.11 (<a href="https://github.com/microsoft/mu_basecore/pull/1016">#1016</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/57770989fcac90b6e4046f5cd9a692afea1f318f">577709</a> pip: update edk2-pytool-extensions requirement from ~=0.27.6 to ~=0.27.8 (<a href="https://github.com/microsoft/mu_basecore/pull/1028">#1028</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/7cf3382ebaf5b5b5a2487d7d13e910c1c7dac233">7cf338</a> pip: update edk2-pytool-extensions requirement from ~=0.27.8 to ~=0.27.9 (<a href="https://github.com/microsoft/mu_basecore/pull/1033">#1033</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/90adf2bc49197314f6d8b2bb40d63d4c5c503065">90adf2</a> BaseTools/Plugin/RustEnvironmentCheck: Use pytools Rust helpers (<a href="https://github.com/microsoft/mu_basecore/pull/1037">#1037</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/1cbfaf1fbc6ef94deba8654afcf2b57104743f4e">1cbfaf</a> MdeModulePkg: Compatibility Mode: Only Remap System Memory Regions</li> </ul> </details> Signed-off-by: Project Mu Bot <mubot@microsoft.com>
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Jul 17, 2024
Introduces 20 new commits in [MU_BASECORE](https://github.com/microsoft/mu_basecore.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_basecore/commit/3a55a400815a25a25a9aa657e99c95edf750188e">3a55a4</a> [CHERRY-PICK] [Release/202311] UnitTestFrameworkPkg: Fix Google Test components with multiple files (<a href="https://github.com/microsoft/mu_basecore/pull/891">#891</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/1475a86d1603236e0c1da7d22d37021c8dc7bf91">1475a8</a> [CHERRY-PICK] [RELEASE/202311] Pulling PixieFail changes from EDK2 for CVE-2023-45237 and CVE-2023-45236 (<a href="https://github.com/microsoft/mu_basecore/pull/897">#897</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/23c33e211ef80511d161d3804ffe5ff4b00c652d">23c33e</a> BaseTools/Plugin/HostBasedUnitTestRunner: Fix invalid escape in HostBasedUnitTest.py (<a href="https://github.com/microsoft/mu_basecore/pull/899">#899</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/f598b780f7ae52d90422750214e2450fa24d4ded">f598b7</a> [CHERRY-PICK] UefiCpuPkg:fix issue when splitting paging entry (<a href="https://github.com/microsoft/mu_basecore/pull/909">#909</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/bbbff00dc39a67dc1e44aa0ce392d460b12f66b9">bbbff0</a> Change CpuDeadLoops to panic calls in PiSmmCpuDxeSmm.c (<a href="https://github.com/microsoft/mu_basecore/pull/892">#892</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/3ab77179e0d08269b155392c44e2f14724114e4e">3ab771</a> Added mock functions for UefiBootServicesTableLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/87b10e679399232d60fefdd6515812bd74571b6d">87b10e</a> Added mock functions for PciExpressLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/5a22ca63d43d7fa162a3adcfbc8d7eb3ffff3c60">5a22ca</a> Added mock functions for TimerLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/86dc06813bc2e1bbd59f06f52b3c97fb722718c0">86dc06</a> pip: update edk2-pytool-library requirement from ~=0.21.6 to ~=0.21.7 (<a href="https://github.com/microsoft/mu_basecore/pull/906">#906</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/e6d01390794aa0505d0659bc484f4d2fdba1e5d4">e6d013</a> pip: update edk2-pytool-extensions requirement from ~=0.27.5 to ~=0.27.6 (<a href="https://github.com/microsoft/mu_basecore/pull/907">#907</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/f9c86cda20d912e2ae6cce5e6daeae01ed6e8b52">f9c86c</a> pip: update edk2-pytool-library requirement from ~=0.21.7 to ~=0.21.8 (<a href="https://github.com/microsoft/mu_basecore/pull/966">#966</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/884e654b29d3611f976d5b9629ae9af920532dd3">884e65</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_basecore/pull/982">#982</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/fd8a09795aa2ea2a091906efb92124eb85d49e05">fd8a09</a> Host Based Unit Test updates (<a href="https://github.com/microsoft/mu_basecore/pull/837">#837</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/307dc02e66899fd9be316a2143783b261375b884">307dc0</a> GitHub Action: Bump robinraju/release-downloader from 1.10 to 1.11 (<a href="https://github.com/microsoft/mu_basecore/pull/1016">#1016</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/57770989fcac90b6e4046f5cd9a692afea1f318f">577709</a> pip: update edk2-pytool-extensions requirement from ~=0.27.6 to ~=0.27.8 (<a href="https://github.com/microsoft/mu_basecore/pull/1028">#1028</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/7cf3382ebaf5b5b5a2487d7d13e910c1c7dac233">7cf338</a> pip: update edk2-pytool-extensions requirement from ~=0.27.8 to ~=0.27.9 (<a href="https://github.com/microsoft/mu_basecore/pull/1033">#1033</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/90adf2bc49197314f6d8b2bb40d63d4c5c503065">90adf2</a> BaseTools/Plugin/RustEnvironmentCheck: Use pytools Rust helpers (<a href="https://github.com/microsoft/mu_basecore/pull/1037">#1037</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/1cbfaf1fbc6ef94deba8654afcf2b57104743f4e">1cbfaf</a> MdeModulePkg: Compatibility Mode: Only Remap System Memory Regions</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/e1eb585136e2689ce7f6fa8a569ea1e331666f33">e1eb58</a> Revert `NO_ABSOLUTE_RELOCS_IN_TEXT` MU change for GCC (<a href="https://github.com/microsoft/mu_basecore/pull/1040">#1040</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/a9612223c13b05682855801c2593c44ff347c0f4">a96122</a> BaseTools/HostBasedUnitTestRunner: Promote Unittest error to CI fail.</li> </ul> </details> Signed-off-by: Project Mu Bot <mubot@microsoft.com>
apop5
referenced
this pull request
in microsoft/mu_tiano_platforms
Jul 22, 2024
Introduces 20 new commits in [MU_BASECORE](https://github.com/microsoft/mu_basecore.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_basecore/commit/3a55a400815a25a25a9aa657e99c95edf750188e">3a55a4</a> [CHERRY-PICK] [Release/202311] UnitTestFrameworkPkg: Fix Google Test components with multiple files (<a href="https://github.com/microsoft/mu_basecore/pull/891">#891</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/1475a86d1603236e0c1da7d22d37021c8dc7bf91">1475a8</a> [CHERRY-PICK] [RELEASE/202311] Pulling PixieFail changes from EDK2 for CVE-2023-45237 and CVE-2023-45236 (<a href="https://github.com/microsoft/mu_basecore/pull/897">#897</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/23c33e211ef80511d161d3804ffe5ff4b00c652d">23c33e</a> BaseTools/Plugin/HostBasedUnitTestRunner: Fix invalid escape in HostBasedUnitTest.py (<a href="https://github.com/microsoft/mu_basecore/pull/899">#899</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/f598b780f7ae52d90422750214e2450fa24d4ded">f598b7</a> [CHERRY-PICK] UefiCpuPkg:fix issue when splitting paging entry (<a href="https://github.com/microsoft/mu_basecore/pull/909">#909</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/bbbff00dc39a67dc1e44aa0ce392d460b12f66b9">bbbff0</a> Change CpuDeadLoops to panic calls in PiSmmCpuDxeSmm.c (<a href="https://github.com/microsoft/mu_basecore/pull/892">#892</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/3ab77179e0d08269b155392c44e2f14724114e4e">3ab771</a> Added mock functions for UefiBootServicesTableLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/87b10e679399232d60fefdd6515812bd74571b6d">87b10e</a> Added mock functions for PciExpressLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/5a22ca63d43d7fa162a3adcfbc8d7eb3ffff3c60">5a22ca</a> Added mock functions for TimerLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/86dc06813bc2e1bbd59f06f52b3c97fb722718c0">86dc06</a> pip: update edk2-pytool-library requirement from ~=0.21.6 to ~=0.21.7 (<a href="https://github.com/microsoft/mu_basecore/pull/906">#906</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/e6d01390794aa0505d0659bc484f4d2fdba1e5d4">e6d013</a> pip: update edk2-pytool-extensions requirement from ~=0.27.5 to ~=0.27.6 (<a href="https://github.com/microsoft/mu_basecore/pull/907">#907</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/f9c86cda20d912e2ae6cce5e6daeae01ed6e8b52">f9c86c</a> pip: update edk2-pytool-library requirement from ~=0.21.7 to ~=0.21.8 (<a href="https://github.com/microsoft/mu_basecore/pull/966">#966</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/884e654b29d3611f976d5b9629ae9af920532dd3">884e65</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_basecore/pull/982">#982</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/fd8a09795aa2ea2a091906efb92124eb85d49e05">fd8a09</a> Host Based Unit Test updates (<a href="https://github.com/microsoft/mu_basecore/pull/837">#837</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/307dc02e66899fd9be316a2143783b261375b884">307dc0</a> GitHub Action: Bump robinraju/release-downloader from 1.10 to 1.11 (<a href="https://github.com/microsoft/mu_basecore/pull/1016">#1016</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/57770989fcac90b6e4046f5cd9a692afea1f318f">577709</a> pip: update edk2-pytool-extensions requirement from ~=0.27.6 to ~=0.27.8 (<a href="https://github.com/microsoft/mu_basecore/pull/1028">#1028</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/7cf3382ebaf5b5b5a2487d7d13e910c1c7dac233">7cf338</a> pip: update edk2-pytool-extensions requirement from ~=0.27.8 to ~=0.27.9 (<a href="https://github.com/microsoft/mu_basecore/pull/1033">#1033</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/90adf2bc49197314f6d8b2bb40d63d4c5c503065">90adf2</a> BaseTools/Plugin/RustEnvironmentCheck: Use pytools Rust helpers (<a href="https://github.com/microsoft/mu_basecore/pull/1037">#1037</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/1cbfaf1fbc6ef94deba8654afcf2b57104743f4e">1cbfaf</a> MdeModulePkg: Compatibility Mode: Only Remap System Memory Regions</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/e1eb585136e2689ce7f6fa8a569ea1e331666f33">e1eb58</a> Revert `NO_ABSOLUTE_RELOCS_IN_TEXT` MU change for GCC (<a href="https://github.com/microsoft/mu_basecore/pull/1040">#1040</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/a9612223c13b05682855801c2593c44ff347c0f4">a96122</a> BaseTools/HostBasedUnitTestRunner: Promote Unittest error to CI fail.</li> </ul> </details> Signed-off-by: Project Mu Bot <mubot@microsoft.com>
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Jul 30, 2024
Introduces 27 new commits in [MU_BASECORE](https://github.com/microsoft/mu_basecore.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_basecore/commit/3a55a400815a25a25a9aa657e99c95edf750188e">3a55a4</a> [CHERRY-PICK] [Release/202311] UnitTestFrameworkPkg: Fix Google Test components with multiple files (<a href="https://github.com/microsoft/mu_basecore/pull/891">#891</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/1475a86d1603236e0c1da7d22d37021c8dc7bf91">1475a8</a> [CHERRY-PICK] [RELEASE/202311] Pulling PixieFail changes from EDK2 for CVE-2023-45237 and CVE-2023-45236 (<a href="https://github.com/microsoft/mu_basecore/pull/897">#897</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/23c33e211ef80511d161d3804ffe5ff4b00c652d">23c33e</a> BaseTools/Plugin/HostBasedUnitTestRunner: Fix invalid escape in HostBasedUnitTest.py (<a href="https://github.com/microsoft/mu_basecore/pull/899">#899</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/f598b780f7ae52d90422750214e2450fa24d4ded">f598b7</a> [CHERRY-PICK] UefiCpuPkg:fix issue when splitting paging entry (<a href="https://github.com/microsoft/mu_basecore/pull/909">#909</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/bbbff00dc39a67dc1e44aa0ce392d460b12f66b9">bbbff0</a> Change CpuDeadLoops to panic calls in PiSmmCpuDxeSmm.c (<a href="https://github.com/microsoft/mu_basecore/pull/892">#892</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/3ab77179e0d08269b155392c44e2f14724114e4e">3ab771</a> Added mock functions for UefiBootServicesTableLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/87b10e679399232d60fefdd6515812bd74571b6d">87b10e</a> Added mock functions for PciExpressLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/5a22ca63d43d7fa162a3adcfbc8d7eb3ffff3c60">5a22ca</a> Added mock functions for TimerLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/86dc06813bc2e1bbd59f06f52b3c97fb722718c0">86dc06</a> pip: update edk2-pytool-library requirement from ~=0.21.6 to ~=0.21.7 (<a href="https://github.com/microsoft/mu_basecore/pull/906">#906</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/e6d01390794aa0505d0659bc484f4d2fdba1e5d4">e6d013</a> pip: update edk2-pytool-extensions requirement from ~=0.27.5 to ~=0.27.6 (<a href="https://github.com/microsoft/mu_basecore/pull/907">#907</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/f9c86cda20d912e2ae6cce5e6daeae01ed6e8b52">f9c86c</a> pip: update edk2-pytool-library requirement from ~=0.21.7 to ~=0.21.8 (<a href="https://github.com/microsoft/mu_basecore/pull/966">#966</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/884e654b29d3611f976d5b9629ae9af920532dd3">884e65</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_basecore/pull/982">#982</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/fd8a09795aa2ea2a091906efb92124eb85d49e05">fd8a09</a> Host Based Unit Test updates (<a href="https://github.com/microsoft/mu_basecore/pull/837">#837</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/307dc02e66899fd9be316a2143783b261375b884">307dc0</a> GitHub Action: Bump robinraju/release-downloader from 1.10 to 1.11 (<a href="https://github.com/microsoft/mu_basecore/pull/1016">#1016</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/57770989fcac90b6e4046f5cd9a692afea1f318f">577709</a> pip: update edk2-pytool-extensions requirement from ~=0.27.6 to ~=0.27.8 (<a href="https://github.com/microsoft/mu_basecore/pull/1028">#1028</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/7cf3382ebaf5b5b5a2487d7d13e910c1c7dac233">7cf338</a> pip: update edk2-pytool-extensions requirement from ~=0.27.8 to ~=0.27.9 (<a href="https://github.com/microsoft/mu_basecore/pull/1033">#1033</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/90adf2bc49197314f6d8b2bb40d63d4c5c503065">90adf2</a> BaseTools/Plugin/RustEnvironmentCheck: Use pytools Rust helpers (<a href="https://github.com/microsoft/mu_basecore/pull/1037">#1037</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/1cbfaf1fbc6ef94deba8654afcf2b57104743f4e">1cbfaf</a> MdeModulePkg: Compatibility Mode: Only Remap System Memory Regions</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/e1eb585136e2689ce7f6fa8a569ea1e331666f33">e1eb58</a> Revert `NO_ABSOLUTE_RELOCS_IN_TEXT` MU change for GCC (<a href="https://github.com/microsoft/mu_basecore/pull/1040">#1040</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/a9612223c13b05682855801c2593c44ff347c0f4">a96122</a> BaseTools/HostBasedUnitTestRunner: Promote Unittest error to CI fail.</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/285f5d8f31ab92156354758fb31e29288f65525d">285f5d</a> Repo File Sync: .sync/rust_config/rustfmt.toml: Use Rust default of 4 space indentation (<a href="https://github.com/microsoft/mu_basecore/pull/1058">#1058</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/c41e6949328e58241970902dc73f62cb12d685ac">c41e69</a> Added mock functions on UefiLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/be93190390309b3d7319a395636f9a2664954acb">be9319</a> Added MockUefiDevicePathLib and gBS_AllocatePool under MockUefiBootServicesTableLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/d9c18c384889d0c445865f96ac660f6abee6115f">d9c18c</a> Added the right copyright info (Intel and Microsoft) on all MockUefiDevicePathLib files</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/cf915a50dbb79d11663fbe254d94d1b39496e057">cf915a</a> BaseTools/codeql: Update to CodeQL 2.18.1 (<a href="https://github.com/microsoft/mu_basecore/pull/1072">#1072</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/856d8a412308b852e53254c10edd0f098933aa8f">856d8a</a> Update BaseCryptLib tests to reference the PCDs before running (<a href="https://github.com/microsoft/mu_basecore/pull/1034">#1034</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/7a2272c02884ebb49283b5520dbddf8085dd1295">7a2272</a> Add deprecation warning support to OverrideValidation plugin (<a href="https://github.com/microsoft/mu_basecore/pull/742">#742</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <mubot@microsoft.com>
apop5
added a commit
to apop5/mu_tiano_platforms
that referenced
this pull request
Aug 3, 2024
apop5
added a commit
to apop5/mu_tiano_platforms
that referenced
this pull request
Aug 3, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impact:non-functional
Does not have a functional impact
impact:testing
Affects testing
type:bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4610
Google Test hides test registration in global constructors on global objects. Global constructors are traditionally implemented by placing references to the global constructor's symbol in special sections (traditionally named .ctors or .init_array). These sections are not explicitly referenced by the linker, and libc only looks at special start and end symbols (and calls them).
This works fine if you're linking a program manually using
but fails miserably when using static libraries (such as what EDK2 does), because traditional static archive symbol resolution rules don't allow for object files to be pulled in to the link if there isn't an undefined symbol reference to that .o elsewhere.
Fix it by passing --whole-archive (GCC) and /WHOLEARCHIVE (MSVC). These options force the linker to pull in the entire static library, thus including previously-unreferenced constructors and making sure multi-file gtest EDK2 components work.
Cc: Michael D Kinney michael.d.kinney@intel.com
Cc: Michael Kubacki mikuback@linux.microsoft.com
Cc: Sean Brogan sean.brogan@microsoft.com
Reviewed-by: Cc: Michael D Kinney michael.d.kinney@intel.com
Description
This corrects an issue with MSVC where unit tests are not being linked correctly - thus creating unit tests with zero tests
For each item, place an "x" in between
[
and]
if true. Example:[x]
.(you can also check items in the GitHub UI)
How This Was Tested
Local builds with Host Based Unit Tests
Integration Instructions
N/A