Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdePkg: Add mocks for AcpiTable and more #1165

Merged

Conversation

VivianNK
Copy link
Contributor

@VivianNK VivianNK commented Sep 26, 2024

Description

Create mock for AcpiTable, FirmwareVolume2 and AcpiSystemDescriptionTable protocols.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Mock consumed in local unit test.

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Sep 26, 2024
@VivianNK VivianNK requested review from apop5 and os-d September 26, 2024 22:31
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.59%. Comparing base (f82e02d) to head (953f333).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405    #1165   +/-   ##
===========================================
  Coverage        1.59%    1.59%           
===========================================
  Files            1448     1448           
  Lines          362501   362501           
  Branches         5632     5632           
===========================================
  Hits             5776     5776           
  Misses         356618   356618           
  Partials          107      107           
Flag Coverage Δ
MdeModulePkg 0.68% <ø> (ø)
MdePkg 5.42% <ø> (ø)
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)
UefiCpuPkg 4.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Description
Create mock for AcpiTable, FirmwareVolume2 and AcpiSystemDescriptionTable
protocols.

Signed-off-by: Vivian Nowka-Keane <vnowkakeane@microsoft.com>
@VivianNK VivianNK force-pushed the personal/vnowkakeane/AcpiTableMock branch from af5eda9 to 953f333 Compare September 26, 2024 23:08
@github-actions github-actions bot added the impact:testing Affects testing label Sep 27, 2024
@VivianNK VivianNK merged commit fe6a1f9 into microsoft:dev/202405 Sep 27, 2024
33 checks passed
VivianNK added a commit to VivianNK/mu_basecore that referenced this pull request Sep 27, 2024
## Description

Create mock for AcpiTable, FirmwareVolume2 and
AcpiSystemDescriptionTable protocols.

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [x] Includes tests?
- [ ] Includes documentation?

## How This Was Tested
Mock consumed in local unit test.

## Integration Instructions
N/A

Signed-off-by: Vivian Nowka-Keane <vnowkakeane@microsoft.com>
Co-authored-by: TsunFeng <v-tshuang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact impact:testing Affects testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants