[Rebase & FF] Bring in changes from release/202405 #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d74b9cf.
Includes changes across the repo for the following CodeQL rules: - cpp/comparison-with-wider-type - cpp/overflow-buffer - cpp/redundant-null-check-param - cpp/uselesstest Co-authored-by: Taylor Beebe <tabeebe@microsoft.com> Co-authored-by: pohanch <125842322+pohanch@users.noreply.github.com> Co-authored-by: kenlautner <85201046+kenlautner@users.noreply.github.com> Co-authored-by: Oliver Smith-Denny <osde@linux.microsoft.com> Co-authored-by: Sean Brogan <sean.brogan@microsoft.com> Co-authored-by: Aaron <105021049+apop5@users.noreply.github.com>
Report PXE error status via Status Code, with this design, it will be flexible to register a status code handler via gEfiRscHandlerProtocolGuid to output the customized error code to other telemetry service. The subclass code is `EFI_IO_BUS_IP_NETWORK` Signed-off-by: Ethan Hsu <Eathonhsu@gmail.com>
## Description Add mocks from 2311 Cherry picked and squashed the following commits: a5ba951 5aa1be5 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested in 202311 CI ## Integration Instructions N/A Signed-off-by: Vivian Nowka-Keane <vnowkakeane@microsoft.com> Co-authored-by: v-sbolisetti <v-sbolisetti@microsoft.com> Co-authored-by: YiTa-AMI <v-yitawu@microsoft.com>
VivianNK
changed the title
apop5
approved these changes
Sep 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #1164 +/- ##
==============================================
- Coverage 1.59% 1.59% -0.01%
==============================================
Files 1448 1448
Lines 362491 362501 +10
Branches 5632 5632
==============================================
Hits 5776 5776
- Misses 356608 356618 +10
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Can you clarify in the PR description why these were in the release branch but not the dev branch? If they just got checked in there first during process transition, that's fine but will eliminate confusion to people trying to understand the new process. |
makubacki
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MU repos recently transitioned to using a dev branch for new changes after a release. In the process of transition, a few commits got checked in to release/202405.
This PR brings in the following commits from release/202405:
91a2538
88b6c1e
95a58f8
ba672c3
How This Was Tested
Tested in release/202405
Integration Instructions
N/A