Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CrowdSec TIProvider #673

Merged
merged 7 commits into from
Jul 25, 2023
Merged

Conversation

sbs2001
Copy link
Contributor

@sbs2001 sbs2001 commented Jun 5, 2023

Added CrowdSec TIProvider.

Unit tests and documentation changes included.

Copy link
Contributor

@ianhelle ianhelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me although Pete said he had spotted an item in the unit test.
I'll leave for him to add comments

docs/source/data_acquisition/TIProviders.rst Outdated Show resolved Hide resolved
docs/source/getting_started/msticpyconfig.rst Outdated Show resolved Hide resolved
msticpy/context/tiproviders/crowdsec.py Outdated Show resolved Hide resolved
tests/context/test_tiproviders.py Show resolved Hide resolved
@ianhelle
Copy link
Contributor

ianhelle commented Jul 6, 2023

Looks like you have an import error (from the tests).
Very likely import datetime vs from datetime import datetime

tests/context/test_tiproviders.py:935: in <module>
    "first_seen": f"{dt.now().isoformat(timespec='seconds')}+00:00",
E   AttributeError: module 'datetime' has no attribute 'now'

Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
@sbs2001
Copy link
Contributor Author

sbs2001 commented Jul 11, 2023

@ianhelle Thanks for the review ! I've pushed commits to implement your suggestions.

@ianhelle
Copy link
Contributor

/azpipelines run

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 673 in repo microsoft/msticpy

…st data for CrowdSec

Added CrowdSec settings entry to test msticpyconfig.yaml and msticpyconfig-test.yaml
@ianhelle
Copy link
Contributor

/azpipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ianhelle
Copy link
Contributor

/azpipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ianhelle ianhelle merged commit f76650d into microsoft:main Jul 25, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants