-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CrowdSec TIProvider #673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me although Pete said he had spotted an item in the unit test.
I'll leave for him to add comments
Looks like you have an import error (from the tests).
|
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
206094d
to
f7e580a
Compare
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
@ianhelle Thanks for the review ! I've pushed commits to implement your suggestions. |
/azpipelines run |
No commit pushedDate could be found for PR 673 in repo microsoft/msticpy |
…st data for CrowdSec Added CrowdSec settings entry to test msticpyconfig.yaml and msticpyconfig-test.yaml
/azpipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Added CrowdSec TIProvider.
Unit tests and documentation changes included.