Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliant CFS configuration #2504

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Compliant CFS configuration #2504

merged 2 commits into from
Sep 9, 2024

Conversation

tkyc
Copy link
Member

@tkyc tkyc commented Aug 26, 2024

This PR is for being compliant with the company's security policies. Msft requires OSS project to pull from a public Azure Artifacts Feed for dependencies.

For open source contributors, you may encounter a 401 error when attempting to download dependencies. In which case, you can wait for a maintainer to update the public Azure Artifact Feed, or you can point the project's pom.xml to maven central instead to get around it.

For maintainers, any time a dependency version is updated, we also need to update the Azure Artifact Feed. Otherwise, public users won't be able to pull the dependency and our internal pipelines would fail.

Maintainers should refer to the internal doc on how to update the public Azure Artifacts Feed.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.67%. Comparing base (fe56e25) to head (a226bb1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2504   +/-   ##
=========================================
  Coverage     50.66%   50.67%           
- Complexity     3826     3828    +2     
=========================================
  Files           145      145           
  Lines         33133    33133           
  Branches       5558     5558           
=========================================
+ Hits          16788    16790    +2     
  Misses        13944    13944           
+ Partials       2401     2399    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jeffery-Wasty Jeffery-Wasty added this to the 12.9.0 milestone Aug 28, 2024
@tkyc tkyc merged commit 3be298f into main Sep 9, 2024
19 checks passed
@tkyc tkyc deleted the s360-maven-cfs branch September 9, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

3 participants