Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access token issue when connection pool enabled #1403

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

absci
Copy link
Contributor

@absci absci commented Jul 19, 2022

No description provided.

@absci absci force-pushed the fix_connection_pool branch 10 times, most recently from b2dde91 to 97983ce Compare July 21, 2022 20:26
@absci absci force-pushed the fix_connection_pool branch 4 times, most recently from 870b7e5 to 72dd098 Compare July 26, 2022 06:02
@absci absci force-pushed the fix_connection_pool branch from 72dd098 to ae1f808 Compare July 26, 2022 06:08
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #1403 (6293a91) into dev (109b8bc) will decrease coverage by 0.44%.
The diff coverage is n/a.

❗ Current head 6293a91 differs from pull request most recent head 2fe3440. Consider uploading reports for the commit 2fe3440 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1403      +/-   ##
==========================================
- Coverage   83.61%   83.17%   -0.45%     
==========================================
  Files          22       22              
  Lines        7853     7897      +44     
==========================================
+ Hits         6566     6568       +2     
- Misses       1287     1329      +42     
Impacted Files Coverage Δ
...x86/php-8.0.19-src/ext/sqlsrv/shared/core_sqlsrv.h
...x86/php-8.0.19-src/ext/sqlsrv/shared/core_stmt.cpp
...s16/x86/php-8.0.19-src/ext/sqlsrv/php_sqlsrv_int.h
...6/x86/php-8.0.19-src/ext/pdo_sqlsrv/pdo_parser.cpp
...vs16/x86/php-8.0.19-src/ext/pdo_sqlsrv/pdo_dbh.cpp
...phpdev/vs16/x86/php-8.0.19-src/ext/sqlsrv/conn.cpp
...php-8.0.19-src/ext/pdo_sqlsrv/shared/core_stmt.cpp
...x86/php-8.0.19-src/ext/sqlsrv/shared/core_conn.cpp
...phpdev/vs16/x86/php-8.0.19-src/ext/sqlsrv/util.cpp
...php-8.0.19-src/ext/pdo_sqlsrv/php_pdo_sqlsrv_int.h
... and 34 more

@absci absci force-pushed the fix_connection_pool branch from 8bc5e4e to 71e7dcd Compare July 27, 2022 19:03
@absci absci force-pushed the fix_connection_pool branch from 71e7dcd to 6293a91 Compare July 27, 2022 19:41
@absci absci requested a review from v-mabarw August 2, 2022 21:47
@v-mabarw v-mabarw requested a review from v-makouz August 29, 2022 23:26
@v-makouz
Copy link
Contributor

Fix for issue #1396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants