This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
Add rust colorization support #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you! ❤️ |
|
No problem. I will have quite a few more of these to contribute in the coming months as we (Bitbucket) roll out Monaco to prod. Did you use a tool like eslint to re-format the code? If so, I'd love to just use your config to save you the work in the future. |
|
Looking forward to further contributions! ❤️ No problem, I'm just running the format action in vscode (shift-alt-f on OSX). That would use the default TypeScript formatter settings I believe... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: microsoft/monaco-editor#130
Add basic colorization support for Rust. There are likely some flaws in here due to the complex nature of tokenizing Rust, but it's a fairly good start. Manually validated many of the edge cases provided by https://github.com/rust-lang/rust-enhanced/blob/master/syntax_test_rust.rs and it seems to be fully functioning.