This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
Terraform HCL : Fixing, Improving, adding tests #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fonsecas72
force-pushed
the
improve-hcl
branch
from
bb1f806 to
62cb60a
Compare
fonsecas72
force-pushed
the
improve-hcl
branch
from
62cb60a to
9d8859a
Compare
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here they are the tests as promised. I fetch them from the official language repo, so they should be relatively good.
I had some doubts about which token class to use because of coloring and I focused mainly on the final look considering the terraform extension for vscode
regardless if something is wrong let me know and I'll fix it
(microsoft/monaco-editor#1710)