Document some basic concepts #4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hediet
requested changes
Jul 18, 2023
README.md
Outdated
|
|
||
| Providers provide smart editor features, also known as IntelliSense. For example, this includes completion and hover information. It is not the same as, but often maps to [language server protocol](https://microsoft.github.io/language-server-protocol) features. | ||
|
|
||
| Providers work on models. Some IntelliSense depends on the file URI. For example, for TypeScript to resolve imports, or for JSON IntelliSense to determine which JSON schema to apply to which model. So it’s important to choose proper model URIs. |
There was a problem hiding this comment.
I'd use "auto-complete", afaik IntelliSense is a Visual Studio only term
There was a problem hiding this comment.
I thought it applied to Monaco editor too, as it was part of VS Code. Good to know this is not the case. :)
I changed it to editors features, as it’s not just auto-complete.
remcohaszing
force-pushed
the
document-concepts
branch
from
3e412ba to
09a944d
Compare
hediet
approved these changes
Jul 19, 2023
|
Thanks! |
roblourens
approved these changes
Jul 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this captures the basics. I’m open to suggestions.
IMO this is brief enough to keep in the readme, but I can move it into
/docs/basic-conceptsor so and link that if that’s preferable.Closes #4084