Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt example #3726

Merged
merged 2 commits into from
Mar 8, 2023
Merged

opt example #3726

merged 2 commits into from
Mar 8, 2023

Conversation

PmcFizz
Copy link
Contributor

@PmcFizz PmcFizz commented Mar 6, 2023

when use iframe and the 'allow-modals' keyword is not set, the alert function is not used .

@hediet
Copy link
Member

hediet commented Mar 8, 2023

Maybe it makes sense to set allow-modals though

@hediet hediet added this to the March 2023 milestone Mar 8, 2023
@hediet hediet enabled auto-merge March 8, 2023 10:21
@hediet hediet merged commit fe18f2e into microsoft:main Mar 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ulugbekna ulugbekna ulugbekna approved these changes

@hediet hediet hediet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
March 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@PmcFizz @hediet @ulugbekna