Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform.js cannot read property 'bind' of undefined #2328

Closed
starpit opened this issue Jan 31, 2021 · 2 comments
Closed

platform.js cannot read property 'bind' of undefined #2328

starpit opened this issue Jan 31, 2021 · 2 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug regression
Milestone
January 2021

Comments

@starpit
Copy link

starpit commented Jan 31, 2021

  • VSCode Version: monaco-editor 0.22.1
  • OS Version: any

Steps to Reproduce:

  1. upgrade from monaco-editor 0.21.2 to 0.22.1
  2. observe the following error message in the console:

node_modules/monaco-editor/esm/vs/base/common/platform.js? 148 Uncaught TypeError: Cannot read property 'bind' of undefined

This regression seems to be caused by this change: microsoft/vscode@76b7331#diff-562a9dd5a425180aed71854ee8a3f2705d38e9f723d763eff63da148456a71e6L199

Whereas previously you were guarding for process.nextTick being undefined, now you are not. In certain webpack configurations, the process shims may not define process.nextTick

Does this issue occur when all extensions are disabled?: Yes, though we have only tried monaco-editor
@alexdima alexdima transferred this issue from microsoft/vscode Feb 1, 2021
@alexdima alexdima added this to the January 2021 milestone Feb 1, 2021
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug regression labels Feb 1, 2021
alexdima added a commit to microsoft/vscode that referenced this issue Feb 1, 2021
@alexdima
Fixes microsoft/monaco-editor#2328: In some webpack configurations, `…
e4d9cb2 
…process` can be defined, while `process.nextTick` is not
@alexdima
Copy link
Member

alexdima commented Feb 1, 2021 •
edited
Loading

Released monaco-editor@0.22.2

@starpit
Copy link
Author

starpit commented Feb 1, 2021

Verified! Thanks so much for the quick fix.

plainerman pushed a commit to plainerman/vscode that referenced this issue Feb 2, 2021
@alexdima @plainerman
Fixes microsoft/monaco-editor#2328: In some webpack configurations, `…
84c78f7 
…process` can be defined, while `process.nextTick` is not
MarcoZehe pushed a commit to MarcoZehe/vscode that referenced this issue Feb 3, 2021
@alexdima @MarcoZehe
Fixes microsoft/monaco-editor#2328: In some webpack configurations, `…
b84006e 
…process` can be defined, while `process.nextTick` is not
@dependabot dependabot bot mentioned this issue Mar 8, 2021
Closed
@renovate renovate bot mentioned this issue May 21, 2021
Open
1 task
@renovate renovate bot mentioned this issue May 29, 2021
Closed
1 task
This was referenced Jun 6, 2021
Open
Open
Open
Closed
Open
Open
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug regression
Projects
None yet
Milestone
January 2021
Development

No branches or pull requests
2 participants
@starpit @alexdima