Fix TreeView root node ItemsSource syncing #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiguo
commented
Jun 13, 2019
| @@ -2578,6 +2578,38 @@ public void TreeViewNodeInMarkupTest() | |||
| } | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| [TestProperty("TestSuite", "B")] | |||
| public void TreeViewRootNodeBindingTest() | |||
There was a problem hiding this comment.
@RBrid there are some async updates when ItemsSource changes, I feel it's easier to do it in interaction test compare to API test (especially with all your helper functions in place to repro the issue 😊).
RBrid
approved these changes
Jun 13, 2019
jevansaks
added
the
release note
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #631
TreeView root node and the rest of other nodes use separate logics to handle ItemsSource&TreeViewNode syncing, which shouldn't be necessary, since root node is no different from other TreeViewNodes. Deleted the duplicated code and let TreeViewNode handle the syncing.