Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListBox: Update selection brushes to improve color contrast and align with ListView #3053

Conversation

Felix-Dev
Copy link
Contributor

@Felix-Dev Felix-Dev commented Aug 5, 2020

Description

As discussed in #2979, this PR updates the selection brushes used for ListBoxItems to now match the recently updated ListViewItem selection brushes.

FYI @YuliKl

Motivation and Context

Closes #2979.

How Has This Been Tested?

Tested visually.

Screenshots:

Light Dark
image image

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Aug 5, 2020
@StephenLPeters StephenLPeters added area-Lists ListView, GridView, ListBox, etc team-Controls Issue for the Controls team labels Aug 5, 2020
@StephenLPeters StephenLPeters requested a review from YuliKl August 5, 2020 23:13
@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Aug 5, 2020
@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters merged commit c37a961 into microsoft:master Aug 6, 2020
@Felix-Dev Felix-Dev deleted the user/Felix-Dev/listboxitem-selecteditem-colorcontrast-update branch August 6, 2020 21:14
Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Lists ListView, GridView, ListBox, etc team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Update background color of selected ListBox item to meet contrast ratio requirement
4 participants