Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming scrolling controls #2730

Merged
merged 3 commits into from
Jun 25, 2020
Merged

Renaming scrolling controls #2730

merged 3 commits into from
Jun 25, 2020

Conversation

RBrid
Copy link
Contributor

@RBrid RBrid commented Jun 22, 2020

These changes focus on renaming classes for the scrolling controls:

ScrollOptions ==> ScrollingScrollOptions
ZoomOptions ==> ScrollingZoomOptions
ScrollAnimationStartingEventArgs ==> ScrollingScrollAnimationStartingEventArgs
ZoomAnimationStartingEventArgs ==> ScrollingZoomAnimationStartingEventArgs
ScrollCompletedEventArgs ==> ScrollingScrollCompletedEventArgs
ZoomCompletedEventArgs ==> ScrollingZoomCompletedEventArgs
ScrollerBringingIntoViewEventArgs ==> ScrollingBringingIntoViewEventArgs
ScrollerAnchorRequestedEventArgs ==> ScrollingAnchorRequestedEventArgs
Scroller ==> ScrollPresenter
ScrollViewer ==> ScrollView
IScrollController::AreInteractionsAllowed ==> IScrollController::AreScrollControllerInteractionsAllowed

There is no functional change here.

Subsequent check-ins will include API changes that resulted from the API review of the ScrollView control that occurred 1/2 year ago.

Somehow even though I used the "git mv" command for all renamed files, some of the files are not showing up as renamed+modified, but rather as removed and added.

This is the work for WinUI 3 task 26277862. After these renames the new scrolling controls can be pushed into the WinUI 3 branches as the ScrollViewer name conflict is gone.

@RBrid RBrid requested a review from a team June 22, 2020 22:36
@RBrid RBrid self-assigned this Jun 22, 2020
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jun 22, 2020
@RBrid
Copy link
Contributor Author

RBrid commented Jun 22, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj added team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jun 24, 2020
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@StephenLPeters
Copy link
Contributor

I didn't look at every change in every file... but the sample I looked at looked as I'd expect it. What a change :)

@RBrid
Copy link
Contributor Author

RBrid commented Jun 25, 2020

Thanks Stephen - sorry for the pain inflicted :-)

@RBrid RBrid merged commit bc468fe into master Jun 25, 2020
@RBrid RBrid deleted the user/rbrid/ScrollerRenamingPR branch June 25, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Scrolling team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants