Fix NavigationView light dismiss issue #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
ranjeshj
added
area-NavigationView
marcelwgn
reviewed
Apr 2, 2020
|
@chingucoding Good point. Added an interaction test now. |
marcelwgn
approved these changes
Apr 2, 2020
|
@Felix-Dev can you please merge with master which includes some stability fixes for the PR pipeline ? |
|
@ranjeshj Done. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the NavigationView light dismiss issue where the NavigationViewItems would not work with the correct closed pane width.
Implementation details
I removed the check if the navigation pane (a SplitView pane) is closed. When we close the pane using the pane toggle button (or set SplitView.IsPaneOpen to false), we were already entering the ListSizeCompact visual state. In other words, splitView.IsPaneOpen() returned false. However, if the pane was light dismissed, splitView.IsPaneOpen() returned true at this point, thus not entering the ListSizeCompact visual state, causing the issue to manifest.
Now that the check is removed, we enter this visual state no matter how the navigation pane is closed . And since we are only calling this code in a handler for the event when the pane is closing (OnSplitViewPaneClosing) having removed this check should not introduce any other side-effects.
Motivation and Context
Fixes #2208
How Has This Been Tested?
Tested visually.
Screenshots
See the following GIF: