Fixed corner radius on the query button on the AutoSuggestBox control #2198
Conversation
msft-github-bot
added
the
needs-triage
yaira2
changed the title
yaira2
changed the title
StephenLPeters
added
area-AutoSuggestBox
area-Styling
team-Controls
|
@chigy as FYI |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@yaichenbaum can you please merge with master which includes some stability fixes for the PR pipeline ? |
|
@ranjeshj Done. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Looks like there were some test failures in this run:
|
|
@yaichenbaum Will you be able to address the visual verification test failures here? |
|
@StephenLPeters I am not sure how I would do that, can I let a little direction on that? |
|
@yaichenbaum You can find instructions on how to update the Visual Tree Verification files here: |
|
@chingucoding Thank you for the link, I will try to get to it over the next few days. |
|
@StephenLPeters I added the new files, can you run the tests again? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@yaichenbaum there are two more visual tree verification masters that need updating AppBarButton-5.xml and AppBarToggleButton-5.xml. @ranjeshj or @kmahone I don't think I would expect this change to be affecting AppBarButton visuals... thoughts? |
| @@ -26,7 +26,7 @@ | |||
| FocusVisualPrimaryThickness=2,2,2,2 | |||
| FocusVisualPrimaryBrush=#FF000000 | |||
| Visibility=Visible | |||
| RenderSize=68,56 | |||
There was a problem hiding this comment.
68,56 [](start = 17, length = 5)
Its possible this file just needs to be reverted. I don't think your change would have caused appBarTOggleButton to be changed
There was a problem hiding this comment.
I am happy to revert the file, just let me know if that is what I should do.
There was a problem hiding this comment.
please revert this, then i'll rerun
There was a problem hiding this comment.
I reverted the changes to this file, should I do that for any other files as well?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Why is the test still failing? |
|
@yaichenbaum Can you please merge in master and I can kick off a new run ? There have been a handful of changes with NavigationView in the past couple of weeks. Thanks! |
|
@ranjeshj Sure. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The test failures on RS4 and RS3 were the result of xml master comparison. NavigationViewTopPaneContent-5.xml and NavigationViewTopPaneContent-6.xml needed to be updated to account for CornerRadius. I've pushed fixes and re-run the build. |
Description
I fixed the query button on the AutoSuggestBox having sharp corners. See the before and after photo.
Motivation and Context
I wanted to fix an inconsistency with the design of the AutoSuggestBox control.
How Has This Been Tested?
I tested this with the MUXControlsTestApp.
Screenshots (if appropriate):
Before
After
Additional context
Sorry for the typo in the commit.