Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move RadialGradientBrush from preview to public #2192

Merged
merged 6 commits into from
Apr 8, 2020
Merged

move RadialGradientBrush from preview to public #2192

merged 6 commits into from
Apr 8, 2020

Conversation

ranjeshj
Copy link
Contributor

Moving RadialGradient brush to public from preview now that the API review is complete. Spec document is here.

@ranjeshj ranjeshj requested a review from jesbis March 30, 2020 16:46
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Mar 30, 2020
@ranjeshj ranjeshj requested a review from MikeHillberg March 30, 2020 16:47
@ranjeshj ranjeshj added area-RadialGradientBrush team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Mar 30, 2020
@marcelwgn
Copy link
Collaborator

The spec still refers to GradientOriginOffset while we renamed it to GradientOrigin . Is there a PR for adjusting the spec to align with the current code? Or is that unecessary?

@ranjeshj
Copy link
Contributor Author

ranjeshj commented Mar 30, 2020 •
edited
Loading

The spec still refers to GradientOriginOffset while we renamed it to GradientOrigin . Is there a PR for adjusting the spec to align with the current code? Or is that unecessary?

Yes. The spec will need to be updated. Do you want to take that up since you made the change :)

@MikeHillberg
Copy link
Contributor

I'm in the process of updating the spec right now.

@ranjeshj
Copy link
Contributor Author

ranjeshj commented Apr 1, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marcelwgn
Copy link
Collaborator

:shipit:

@StephenLPeters
Copy link
Contributor

Does the Spec now align with the idl? @chingucoding @ranjeshj or @MikeHillberg ?

@marcelwgn
Copy link
Collaborator

The idl is aligned with what was discussed. I think @MikeHillberg is in the process of getting the spec up to date with the current API. So yes, IDL aligns with the spec that was discussed.

@marcelwgn marcelwgn mentioned this pull request Apr 6, 2020
Merged
@ranjeshj ranjeshj requested review from codendone and kmelmon April 7, 2020 15:30
@ranjeshj
Copy link
Contributor Author

ranjeshj commented Apr 7, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj merged commit 990fc68 into master Apr 8, 2020
@ranjeshj ranjeshj deleted the user/ranjeshj/radialbrush branch April 8, 2020 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters approved these changes

@jesbis jesbis Awaiting requested review from jesbis

@MikeHillberg MikeHillberg Awaiting requested review from MikeHillberg

@codendone codendone Awaiting requested review from codendone

@kmelmon kmelmon Awaiting requested review from kmelmon

Assignees
No one assigned
Labels
area-RadialGradientBrush team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ranjeshj @marcelwgn @MikeHillberg @StephenLPeters @msft-github-bot