Update GradientOrigin property to align with WPF naming #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
ranjeshj
added
area-RadialGradientBrush
team-Controls
marcelwgn
changed the title
ranjeshj
reviewed
Mar 29, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
approved these changes
Mar 29, 2020
|
@chingucoding want to update the PR description for history with the property name fix as well to |
|
@michael-hawker Thanks for pointing that out, fixed now! |
|
In addition to the naming, we should be aligning value spaces: GradientOrigin, EllipseCenter, and EllipseRadius should be ratios ([0,1]) rather than percentages ([0,100]). |
tracking via #2193 What does it mean for Radius to be 0 to 1 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update naming from "GradientOriginOffset" to "GradientOrigin" and change the offsetting behavior from Center to TopLeft.
Motivation and Context
Closes #2180
How Has This Been Tested?
Ran interaction tests
Screenshots (if appropriate):