Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate entry causing solution load errors. #1987

Merged
merged 6 commits into from
Mar 2, 2020

Conversation

ranjeshj
Copy link
Contributor

RadioButton_themeresources.xaml is included from multiple projects causing the mux project to not load in visual studio. msbuild seems to happily ignore it though - so it does not cause a build break in the pipelines.

Fixes #1982

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Feb 17, 2020
@ranjeshj ranjeshj removed the needs-triage Issue needs to be triaged by the area owners label Feb 18, 2020
@ojhad
Copy link
Contributor

ojhad commented Feb 18, 2020

  <Type>ThemeResources</Type>

Out of curiosity, why delete the 'DefaultStyle' type duplicate entry instead of the 'ThemeResources' type?


Refers to: dev/RadioButtons/RadioButtons.vcxitems:38 in 868a941. [](commit_id = 868a941, deletion_comment = False)

@marcelwgn
Copy link
Collaborator

marcelwgn commented Feb 18, 2020

@ojhad The thing is that the ThemeResource is also referenced in the CommonStyles.vcxitems file, while the other is not. I have to admit its quite confusing that we have "RadioButton_themeresources.xaml" and "RadioButtons_themeresources.xaml".

@marcelwgn
Copy link
Collaborator

On a different note, maybe we could also remove the reference to the "RadioButton_themeresource.xaml" file from here:

<Page Include="$(MSBuildThisFileDirectory)..\RadioButtons\RadioButton_themeresources.xaml">
<Version>RS1</Version>
<Type>ThemeResources</Type>
</Page>

The RadioButton file is the only file referenced there that is not in the "CommonStyles" folder but sits in another project.

@ranjeshj
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone
Copy link
Member

kmahone commented Feb 19, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj
Copy link
Contributor Author

uttons/RadioButtons.vcxitems:38 in 868a941. [](commit_id = 868a941, deletion_comment =

This took a bit of digging, but turns out we use these tags in our targets/build tasks to put together what goes in the themeresources and generic.xaml. See here for more.

@ranjeshj
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters
Copy link
Contributor

@ranjeshj want to move this in?

@ranjeshj ranjeshj merged commit 6fe0c48 into master Mar 2, 2020
@ranjeshj ranjeshj deleted the user/ranjeshj/projectloadissue branch March 2, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to properly compile?
6 participants