-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove duplicate entry causing solution load errors. #1987
Conversation
@ojhad The thing is that the ThemeResource is also referenced in the CommonStyles.vcxitems file, while the other is not. I have to admit its quite confusing that we have "RadioButton_themeresources.xaml" and "RadioButtons_themeresources.xaml". |
On a different note, maybe we could also remove the reference to the "RadioButton_themeresource.xaml" file from here: microsoft-ui-xaml/dev/CommonStyles/CommonStyles.vcxitems Lines 17 to 20 in ee03bac
The RadioButton file is the only file referenced there that is not in the "CommonStyles" folder but sits in another project. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This took a bit of digging, but turns out we use these tags in our targets/build tasks to put together what goes in the themeresources and generic.xaml. See here for more. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@ranjeshj want to move this in? |
RadioButton_themeresources.xaml is included from multiple projects causing the mux project to not load in visual studio. msbuild seems to happily ignore it though - so it does not cause a build break in the pipelines.
Fixes #1982