Fix NavView issue with SelectionChanged being raised upon displaymode change #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
marcelwgn
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
area-NavigationView
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ojhad
reviewed
Mar 4, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@chingucoding looks like some of the tests are real... I can't imagine the acrylic brush failures are related but maybe the nav view failures put us in a bad state.. |
|
@StephenLPeters , I fixed the bug causing the NavigationView test failures. Regarding the Acrylic tests, I guess it is because of the failing NavigationView tests. Strangely, the Acrylic test failures also do not show up on the error list in the "Checks" tab of this PR, they just show up in the Azure portal (well at least on my machine/account). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ojhad
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed code where we update the settings item to set the m_shouldIgnoreNextSelectionChange flag to true, so SelectionChanged ignores that selection change. Also added a check for
m_shouldIgnoreNextSelectionChangeinChangeSelection().Motivation and Context
Fixes #148 , Fixes #1976, Fixes #1956
How Has This Been Tested?
Added new interaction test.
Screenshots (if appropriate):