Update to use new SpanningRects API instead of DisplayRegions. #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
kmahone
added
area-TwoPaneView
team-Controls
| @@ -26,6 +26,7 @@ TwoPaneView::TwoPaneView() | |||
| SetDefaultStyleKey(this); | |||
|
|
|||
| SizeChanged({ this, &TwoPaneView::OnSizeChanged }); | |||
| winrt::Window::Current().SizeChanged({ this, &TwoPaneView::OnWindowSizeChanged }); | |||
There was a problem hiding this comment.
winrt::Window::Current().SizeChanged({ this, &TwoPaneView::OnWindowSizeChanged }); [](start = 4, length = 82)
I think this is not island friendly, I think we need to use appwindow.
There was a problem hiding this comment.
The dual-screen part of TwoPaneView doesn't work in islands, because we are tied to app view. Comp/shell work needs to be done in order for us to be able to be island-friendly.
jevansaks
reviewed
Jan 8, 2020
dev/dll/SharedHelpers.cpp
Outdated
| return s_isApplicationViewGetDisplayRegionsAvailable; | ||
| static bool s_isApplicationViewGetSpanningRectsAvailable = | ||
| winrt::ApiInformation::IsMethodPresent(L"Windows.UI.ViewManagement.ApplicationView", L"GetSpanningRects"); | ||
| return s_isApplicationViewGetSpanningRectsAvailable; |
There was a problem hiding this comment.
ApiInformation checks aren't cheap, can we just use the QueryInterface as the gateway and delete this helper? If we can't QI for the special interface then it doesn't matter what the metadata says.
jevansaks
approved these changes
Jan 8, 2020
ranjeshj
pushed a commit
that referenced
this pull request
Feb 4, 2020
* Update to use new SpanningRects API instead of DisplayRegions.
ranjeshj
pushed a commit
that referenced
this pull request
Feb 9, 2020
* Update to use new SpanningRects API instead of DisplayRegions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shell added a new API called SpanningRects, which is to replace DisplayRegions, so I'm updating TwoPaneView. Since it's not in the released SDK yet, I added the API to my own idl temporarily. Verified that it works on the latest VM in both double landscape and double portrait, when spanning and unspanning. It's necessary to listen to Window.SizeChanged because it fires at the right time when unspanning; shell may have further work to do on a timing here.