Fix bug with UniformGridLayout MaximumRowsOrColumns and requested size #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ranjeshj
reviewed
Jan 2, 2020
| availableSizeMinor : | ||
| std::max(0.0f, itemsCount * GetMinorSizeWithSpacing(context) - static_cast<float>(MinItemSpacing())); |
There was a problem hiding this comment.
FlowLayout likely has the same issue as well.
There was a problem hiding this comment.
I just looked at FlowLayout(Algorithm).cpp and it didn't seem like that the same issue was also present there.
ranjeshj
added
area-ItemsRepeater
team-Controls
| availableSizeMinor : | ||
| std::max(0.0f, itemsCount * GetMinorSizeWithSpacing(context) - static_cast<float>(MinItemSpacing())); | ||
| std::max(0.0f, itemsPerLine * GetMinorSizeWithSpacing(context) - static_cast<float>(MinItemSpacing())); |
There was a problem hiding this comment.
0.0f [](start = 21, length = 4)
Should this be capped to availableSizeMinor? @ranjeshj
There was a problem hiding this comment.
This is correct. If there are any items present, we should size the extent based on the item sizes irrespective of what the available size that was provided by the parent.
In reply to: 362570947 [](ancestors = 362570947)
ranjeshj
approved these changes
Jan 2, 2020
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug where the UniformGridLayout would ignore thefact that it only renders a certain amount of columns/rows and then request the whole width/height instead of requesting what is needed.
Motivation and Context
Fixes #1549
How Has This Been Tested?
Added new API test.
Screenshots (if appropriate):