Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binding to name of NavigationView for menu lists, Closes #564 #1266

Merged

Conversation

marcelwgn
Copy link
Collaborator

Summary

Added template binding to the UIA name of the lists of the navigation items.

Motivation

Closes #564

Testing methodology

Tested by creating a NavigationView in top and in left display mode and navigating through it with Narrator(controls+windows key+enter) enabled

@marcelwgn marcelwgn requested a review from a team as a code owner September 3, 2019 20:25
@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jevansaks jevansaks added the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label Sep 9, 2019
@jevansaks jevansaks added the release note PR that we want to call out in the next release summary label Sep 10, 2019
@jevansaks jevansaks merged commit 580e5ce into microsoft:master Sep 10, 2019
@jevansaks jevansaks removed the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label Sep 11, 2019
@marcelwgn marcelwgn deleted the navigationview-UIA-name-for-list branch September 13, 2019 11:49
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.2.190917002 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.3.191007001-prerelease has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release note PR that we want to call out in the next release summary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NavigationView menu items list does not have AutomationProperties.Name set
5 participants