Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberBox TextAlignment property is missing #7399

Closed
1 of 2 tasks
bogdan-patraucean opened this issue Jul 19, 2022 · 6 comments
Closed
1 of 2 tasks

NumberBox TextAlignment property is missing #7399

bogdan-patraucean opened this issue Jul 19, 2022 · 6 comments
Assignees
Labels
area-NumberBox NumberBox Control duplicate This issue or pull request already exists product-winui3 WinUI 3 issues team-Controls Issue for the Controls team

Comments

@bogdan-patraucean
Copy link

Describe the bug

I want to center the text inside a NumberBox, but the TextAlignment property available in this documentation can't be used with WinUI 3.

Steps to reproduce the bug

  1. Use a NumberBox control with WASDK 1.1 and WinUI3.
  2. Try to use the TextAlignment property, spoiler alert: not available!
<NumberBox Width="100" Value="10" TextAlignment="Center"></NumberBox>

Expected behavior

I expect the property to be available for use as it's part of the documentation and also added in WinUI library two years ago according to this PR.

Screenshots

No response

NuGet package version

WinUI 3 - Windows App SDK 1.1.2

Windows app type

  • UWP
  • Win32

Device form factor

Desktop

Windows version

Windows Insider Build (xxxxx)

Additional context

No response

@bogdan-patraucean bogdan-patraucean added the bug Something isn't working label Jul 19, 2022
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jul 19, 2022
@bogdan-patraucean
Copy link
Author

#1722

@krschau
Copy link
Contributor

krschau commented Jul 20, 2022

I think the reason this isn't available is because it's marked as an experimental API, so it won't be in release builds.
@ranjeshj @MikeHillberg Is this something we can change?

@krschau krschau added needs-assignee-attention Assignee needs to follow-up or investigate this issue team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jul 20, 2022
@krschau krschau self-assigned this Jul 20, 2022
@krschau krschau added product-winui3 WinUI 3 issues area-NumberBox NumberBox Control and removed bug Something isn't working labels Jul 21, 2022
@krschau
Copy link
Contributor

krschau commented Jul 21, 2022

I just found that this has been asked before in #4697

There's a suggestion there for if you want this right away: #4697 (comment)

I'm going to close this issue as a dupe of that one, just because the other issue already has an internal task tracking it (https://task.ms/32309254). I'm going to continue to work on getting this API promoted to stable.

@krschau
Copy link
Contributor

krschau commented Jul 21, 2022

Duplicate of #4697

@krschau krschau marked this as a duplicate of #4697 Jul 21, 2022
@krschau krschau closed this as completed Jul 21, 2022
@krschau krschau added duplicate This issue or pull request already exists and removed needs-assignee-attention Assignee needs to follow-up or investigate this issue labels Jul 21, 2022
@bogdan-patraucean
Copy link
Author

Ok, @krschau, I hope we will see this soon as available.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jul 22, 2022
@krschau krschau removed the needs-triage Issue needs to be triaged by the area owners label Aug 2, 2022
@AndrewKeepCoding
Copy link
Contributor

AndrewKeepCoding commented May 9, 2023

For those who needs this immediately, I have published NumberBoxEx for this. You can get it as NuGet package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NumberBox NumberBox Control duplicate This issue or pull request already exists product-winui3 WinUI 3 issues team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

3 participants