Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Add TextAlignment property to NumberBox #1722

Closed
sonnemaf opened this issue Dec 5, 2019 · 4 comments · Fixed by #2901
Closed

Proposal: Add TextAlignment property to NumberBox #1722

sonnemaf opened this issue Dec 5, 2019 · 4 comments · Fixed by #2901
Assignees
@SavoySchuler @teaP
Labels
area-NumberBox NumberBox Control feature proposal New feature proposal team-Controls Issue for the Controls team

Comments

@sonnemaf
Copy link
Contributor

sonnemaf commented Dec 5, 2019

Proposal: Add TextAlignment property to NumberBox

Summary

It would be nice if NumberBox also had a TextAlignment property.

In this screenshot the NumberBoxes have Right TextAlignment
image

Rationale

  • Make it consistent with TextBox and Excel
  • Creating a Template for the NumberBox with only this extra property is a lot of work. Do-able but not nice.
<TextBox x:Name="InputBox"
                                     Grid.Column="0"
                                     TextAlignment="Right"
                                     Header="{TemplateBinding Header}"
                                     HeaderTemplate="{TemplateBinding HeaderTemplate}"
                                     PreventKeyboardDisplayOnProgrammaticFocus="{TemplateBinding PreventKeyboardDisplayOnProgrammaticFocus}"
                                     PlaceholderText="{TemplateBinding PlaceholderText}"
                                     SelectionHighlightColor="{TemplateBinding SelectionHighlightColor}"
                                     TextReadingOrder="{TemplateBinding TextReadingOrder}" />

Scope

Important Notes

Open Questions
@sonnemaf sonnemaf added the feature proposal New feature proposal label Dec 5, 2019
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Dec 5, 2019
@YuliKl YuliKl added area-NumberBox NumberBox Control team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Dec 5, 2019
@SavoySchuler SavoySchuler mentioned this issue Dec 7, 2019
Open
@SavoySchuler
Copy link
Member

Linked in: #1736

@Felix-Dev Felix-Dev mentioned this issue Jul 13, 2020
Open
@Felix-Dev
Copy link
Contributor

@SavoySchuler Is this something the community can address while the team is busy working on WinUI 3?

@sonnemaf sonnemaf mentioned this issue Jul 14, 2020
Merged
@SavoySchuler
Copy link
Member

Sorry for the late reply @Felix-Dev, it appears @sonnemaf and @StephenLPeters have already merged the PR.

@bogdan-patraucean
Copy link

I'm using WindowsAppSDK and I can't find the TextAlignment property on my WinUI 3 NumberBox control. Any idea why is this not available?

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jul 18, 2022
@bogdan-patraucean bogdan-patraucean mentioned this issue Jul 19, 2022
Closed
2 tasks
@ojhad ojhad removed the needs-triage Issue needs to be triaged by the area owners label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SavoySchuler SavoySchuler

@teaP teaP

Labels
area-NumberBox NumberBox Control feature proposal New feature proposal team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TextAlignment property added to NumberBox sonnemaf/microsoft-ui-xaml
8 participants
@Felix-Dev @ojhad @sonnemaf @YuliKl @SavoySchuler @bogdan-patraucean @teaP @msft-github-bot