Fix issue with NavigationViewItem announcing collapsed when not havin…

…g children (#2770) * Fix issue with collapse being announced on NavViewItem with no children * Add test
microsoft · Jul 7, 2020 · 24197cc · 24197cc
1 parent e975aef
commit 24197cc
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 3 deletions.
diff --git a/dev/NavigationView/NavigationViewItem.h b/dev/NavigationView/NavigationViewItem.h
@@ -69,6 +69,7 @@ class NavigationViewItem :
     void RotateExpandCollapseChevron(bool isExpanded);
     bool IsRepeaterVisible();
     void PropagateDepthToChildren(int depth);
+    bool HasChildren();
 
 private:
     void UpdateNavigationViewItemToolTip();
@@ -97,7 +98,6 @@ class NavigationViewItem :
     bool IsOnLeftNav();
     bool IsOnTopPrimary();
     bool HasChildren();
-
     void UpdateRepeaterItemsSource();
     void ReparentRepeater();
     void ReparentContent();

diff --git a/dev/NavigationView/NavigationViewItemAutomationPeer.cpp b/dev/NavigationView/NavigationViewItemAutomationPeer.cpp
@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
+// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See LICENSE in the project root for license information.
 
 #include "pch.h"
@@ -48,7 +48,8 @@ winrt::IInspectable NavigationViewItemAutomationPeer::GetPatternCore(winrt::Patt
 {
     if (pattern == winrt::PatternInterface::SelectionItem ||
         pattern == winrt::PatternInterface::Invoke ||
-        pattern == winrt::PatternInterface::ExpandCollapse)
+        // Only provide expand collapse pattern if we have children!
+        (pattern == winrt::PatternInterface::ExpandCollapse && HasChildren()))
     {
         return *this;
     }
@@ -457,3 +458,12 @@ void NavigationViewItemAutomationPeer::ChangeSelection(bool isSelected)
         nvi.IsSelected(isSelected);
     }
 }
+
+bool NavigationViewItemAutomationPeer::HasChildren()
+{
+    if (const auto& navigationViewItem = Owner().try_as<NavigationViewItem>())
+    {
+        return navigationViewItem->HasChildren();
+    }
+    return false;
+}
diff --git a/dev/NavigationView/NavigationViewItemAutomationPeer.h b/dev/NavigationView/NavigationViewItemAutomationPeer.h
@@ -62,4 +62,5 @@ class NavigationViewItemAutomationPeer :
     int32_t GetPositionOrSetCountInLeftNavHelper(AutomationOutput automationOutput);
     int32_t GetPositionOrSetCountInTopNavHelper(AutomationOutput automationOutput);
     void ChangeSelection(bool isSelected);
+    bool HasChildren();
 };
diff --git a/dev/NavigationView/NavigationView_ApiTests/NavigationViewTests.cs b/dev/NavigationView/NavigationView_ApiTests/NavigationViewTests.cs
@@ -482,6 +482,37 @@ public void VerifyNavigationItemUIAType()
             });
         }
 
+        [TestMethod]
+        public void VerifyAutomationPeerExpandCollapsePatternBehavior()
+        {
+            RunOnUIThread.Execute(() =>
+            {
+
+                var menuItem1 = new NavigationViewItem();
+                var menuItem2 = new NavigationViewItem();
+                var menuItem3 = new NavigationViewItem();
+                var menuItem4 = new NavigationViewItem();
+                menuItem1.Content = "Item 1";
+                menuItem2.Content = "Item 2";
+                menuItem3.Content = "Item 3";
+                menuItem4.Content = "Item 4";
+
+                menuItem2.MenuItems.Add(menuItem3);
+                menuItem4.HasUnrealizedChildren = true;
+
+                var expandPeer = NavigationViewItemAutomationPeer.CreatePeerForElement(menuItem1).GetPattern(PatternInterface.ExpandCollapse);
+
+                Verify.IsNull(expandPeer,"Verify NavigationViewItem with no children has no ExpandCollapse pattern");
+
+                expandPeer = NavigationViewItemAutomationPeer.CreatePeerForElement(menuItem2).GetPattern(PatternInterface.ExpandCollapse);
+                Verify.IsNotNull(expandPeer,"Verify NavigationViewItem with children has an ExpandCollapse pattern provided");
+
+                expandPeer = NavigationViewItemAutomationPeer.CreatePeerForElement(menuItem4).GetPattern(PatternInterface.ExpandCollapse);
+                Verify.IsNotNull(expandPeer,"Verify NavigationViewItem without children but with UnrealizedChildren set to true has an ExpandCollapse pattern provided");
+            });
+        }
+
+
         [TestMethod]
         public void VerifySettingsItemToolTip()
         {