-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine explore strategy, add prioritized sampling support; add DDQN example; add DQN test #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinyu-W
reviewed
May 18, 2023
**kwargs: Any, | ||
) -> np.ndarray: | ||
return np.array( | ||
[act if np.random.random() > self._eps else np.random.randint(self._num_actions) for act in action], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for batch operation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add input and output description for newly added class/functions
Update the title and description of this PR |
Jinyu-W
force-pushed
the
huoran/ddqn_and_prio_memory
branch
from
May 22, 2023 06:36
2811239
to
a09750e
Compare
Jinyu-W
reviewed
May 22, 2023
Jinyu-W
changed the title
Huoran/ddqn and prio memory
Refine explore strategy, add prioritized sampling support; add DDQN example; add DQN test
May 23, 2023
Jinyu-W
approved these changes
May 23, 2023
Jinyu-W
added a commit
that referenced
this pull request
Oct 27, 2023
* Refine explore strategy, add prioritized sampling support; add DDQN example; add DQN test (#590) * Runnable. Should setup a benchmark and test performance. * Refine logic * Test DQN on GYM passed * Refine explore strategy * Minor * Minor * Add Dueling DQN in CIM scenario * Resolve PR comments * Add one more explanation * fix env_sampler eval info list issue * update version to 0.3.2a4 --------- Co-authored-by: Huoran Li <huoranli@microsoft.com> Co-authored-by: Jinyu Wang <Wang.Jinyu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue(s)/Pull request(s)
Type of Change
Related Component
Has Been Tested
Needs Follow Up Actions
Checklist