Python frame speedup #196
Merged
Python frame speedup #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic! |
|
Set a variant of the MazeRunner running that attempted to save every frame to disk. Over the weekend it saved around 3.7 million pngs, at 860x480 pixels each, amounting to 438GB of data. Frame rate stayed solid, memory use stayed level, and the time to save each png seemed to remain around the same (between 50-60ms). No crashes, nothing degrading, and nothing caught fire. I think it's safe to merge... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #187, amounting to a 100x speedup, which is nice.
Integration tests are all passing, but I shall leave a stress test running over the weekend to check this change doesn't introduce any memory leaks.