Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add devcontainer support to repo #234

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Add devcontainer support to repo #234

merged 1 commit into from
Jul 7, 2023

Conversation

timheuer
Copy link
Member

@timheuer timheuer commented Jul 6, 2023

Adds devcontainer support to the repo for easier use on Codespaces or VS Code remote dev

@timheuer
Copy link
Member Author

timheuer commented Jul 6, 2023

@karthiknadig I can't add a label

@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Jul 6, 2023
@karthiknadig karthiknadig self-assigned this Jul 6, 2023
@karthiknadig karthiknadig merged commit f3f7f30 into microsoft:main Jul 7, 2023
@anthonykim1
Copy link
Contributor

anthonykim1 commented Jul 7, 2023 •
edited by karthiknadig
Loading

I will add/change to have multiple versions of python with different base image!

@timheuer
Copy link
Member Author

timheuer commented Jul 8, 2023

I will add/change to have multiple versions of python with different base image!

Nice, yeah wasn't sure if you needed them other than the latest for the repo, but an easy change add to features

		"ghcr.io/devcontainers/features/python:1": {
			"installTools": true,
			"versions": [
				"3.7",
				"3.8",
				"3.9",
				"3.10",
				"3.11"
			]
		}

@anthonykim1 anthonykim1 mentioned this pull request Sep 5, 2023
Merged
3 tasks
anthonykim1 added a commit that referenced this pull request Sep 7, 2023
@anthonykim1
Dev Container for lsprotocol (#267)
c9a8424 
Dev Container support for lsprotocol repository, referencing #234 and
adding more things on the way, such as multiple Python versions, cargo,
dotnet, venv, requirements, but in a way similar to how dev container is
done in the VS Code Python repo:
microsoft/vscode-python#21675

- [x] Add devcontainer.json, onCreateCommand.sh, postCreateCommand.sh
appropriately
- [x] Add installation and append to PATH for Cargo, Rust, Python(s)
- [x] Install requirements from postCreateCommand.sh after activating
virtual environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonykim1 anthonykim1 anthonykim1 approved these changes

@karthiknadig karthiknadig karthiknadig approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon

Assignees

@karthiknadig karthiknadig

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timheuer @anthonykim1 @karthiknadig