Deprecate old term gallery in favor of new "Marketplace". #1259
Conversation
glima
force-pushed
the
main
branch
3 times, most recently
from
f0115de to
7c4af14
Compare
docs/development.md
Outdated
| @@ -27,7 +27,14 @@ Follow the [instal](install.md) steps to prepare the source code. Then follow th | |||
|
|
|||
| ### Visual Studio Code | |||
|
|
|||
| First, click on the Python version at the bottom left and enter the path where the above command was issued. This will point the Code to the Poetry virtual environment. | |||
| First, click on the Python version at the bottom left of the editor's | |||
| window and enter the path where the above command was issued. You | |||
There was a problem hiding this comment.
Can it be put in troubleshooting? It's not met in every setup.
There was a problem hiding this comment.
I don't get it. If you do what I added, then VSCode seems to start guessing right every next time you open it, so it is a setup instruction. You move it after we merge, if it pleases you, OK?
There was a problem hiding this comment.
The poetry bases on current folder to provide different environments. My understanding is if we get current Python path right, the poetry can make its venv path right. So if provide poetry venv settings here, it may be confusing which Python underlying the poetry.
I'm using poetry with anaconda together. I just need to create an env in anaconda, and poetry will leverage that folder, and no other venv created. It doesn't need to put the venv path into settings.
So I hope this part can be moved to troubleshooting part, let users pick it up based on what problem they meet. If you don't have bandwidth on this part. Can you describe what problem you met, and put the content into an issue? I will update this part later.
There was a problem hiding this comment.
Well I'm not attached to this piece of text, so be it. But we'd better stop practising things and documenting others, like using conda + poetry, no? Are you doing this python-poetry/poetry#1432 ? Try using it with poetry and vscode only and see if it can guess your venv everytime you switch the workplace :) The text is gone now.
docs/development.md
Outdated
| @@ -56,6 +63,10 @@ Make sure below settings are in root level of `.vscode/settings.json`. | |||
| } | |||
| ``` | |||
|
|
|||
| While the black formatter does not handle long comments and the like | |||
There was a problem hiding this comment.
How about add the explanation in "Other setups"? The link of rewrap can be provided like "Markdown All in One". It doesn't need to mention the black formatter, it's not related to the instruction.
There was a problem hiding this comment.
I'll keep the black remark. It's something it should be doing, instead of letting others do it manually.
|
@glima Can we make this PR is simple to its original purpose? We can have different PRs for other topics. |
|
Yeah, new commit mover over to diff PR. Let's not hold this needlessly anymore. |
| One](https://marketplace.visualstudio.com/items?itemName=yzhang.markdown-all-in-one). | ||
| It helps to maintain the table of contents in the documentation. | ||
| - While the black formatter does not handle long comments and the like | ||
| well (https://github.com/psf/black/issues/1331), you might want to |
There was a problem hiding this comment.
@glima I will merge those PRs. I may update the statements later. We represent Microsoft's points. we can provide constructive suggestions what we can. And we consider what value provided to users.
|
@glima I tried to fix it from online. It produces another commit. And it's not a good practice to force push your branch. If we want to rebase and merge, can you help on fixup my last commit? |
We use that to refer to Azure Marketplace, as in https://azuremarketplace.microsoft.com/en-us/marketplace/apps?filters=virtual-machine-images%3Blinux&page=1
Point out that Rewrap is an option for line wrapping, once black does not handle it all. Finally, cite a better option to handle multiple Python venvs in that editor.
|
Updated with conflicts fixed. |
We use that to refer to Azure Marketplace, as in
https://azuremarketplace.microsoft.com/en-us/marketplace/apps?filters=virtual-machine-images%3Blinux&page=1