-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the query format/syntax for WorkspaceSymbolParams #1674
Comments
It's arbitrary, whatever the server implemented. In practice it might be a subsequence match or a prefix match. From client and/or protocol perspective it's just a string. |
This is a string the client passes to the server:
This means that the language server needs to know how to handle that query string when matching symbols. At the very least, it should be required for the client to document the query string format. -- Ideally, this should be described in the client capabilities. The protocol is supposed to be designed to make it easier for any client and language server to be implemented. Here, the language server needs to know the client, what query strings it supports, and switch behaviour on that. -- This is because symbols can be different depending on the regex/query syntax used. Having the format in the protocol request (like is done with things like the regex and markdown formats) would at least make it easier to implement the logic for. |
I agree that this needs to be improved but I am not sure yet how :-( |
In WorkspaceSymbolParams, the
query
parameter states:It is unclear what syntax the query string has, and how a language server is supposed to process that query when matching symbols.
String.replace*
)?Q{namespace}local-name
notation or similar?The text was updated successfully, but these errors were encountered: