Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/ruby generation #3107

Merged
merged 15 commits into from
Aug 14, 2023
Merged

bugfix/ruby generation #3107

merged 15 commits into from
Aug 14, 2023

Conversation

baywet
Copy link
Member

@baywet baywet commented Aug 9, 2023

@baywet baywet self-assigned this Aug 9, 2023
@baywet baywet mentioned this pull request Aug 9, 2023
Open
baywet added 12 commits August 10, 2023 11:36
@baywet
- draft ruby flattening fix
a7531c9
@baywet
- fixes dotnet configuration due to extension changes
3a267ba 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- fixes names normalization process
2c99dde 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- links setter to type definition
71bce0a 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- code linting
12d7ed5 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- fixes reference to query parameters type in python
70e3203 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- adds changelog entry for ruby fixes
f00933c 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- adds test for flattening method coverage
30a9daf 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- moves flattening earlier to avoid extraneous imports
e457499 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- fixes reserved names replacement
381c315 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
- fixes property writer unit test for python
24e7668
@baywet
- fixes a bug where internal types would be renamed when they shouldn't
c61c7dc 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet force-pushed the bugfix/ruby-generation branch from 9b4420f to c61c7dc Compare August 10, 2023 15:36
baywet added 2 commits August 10, 2023 12:30
@baywet
- fixes wrongly defined unit test
7bd32bd
@baywet
- fixes additional failing test
f4deac5 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet marked this pull request as ready for review August 10, 2023 16:54
@baywet baywet requested a review from a team as a code owner August 10, 2023 16:54
@baywet baywet enabled auto-merge August 10, 2023 16:55
andrueastman
andrueastman reviewed Aug 11, 2023
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Appreciate the reduced name/string duplication.
This also looks fixes a bug in C# where property names were being renamed unnecessarily if the property type was being renamed and they both (type and property itself) had the same name 😄

src/Kiota.Builder/Refiners/TypeScriptRefiner.cs Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.7% 95.7% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit 415c8ce into main Aug 14, 2023
@baywet baywet deleted the bugfix/ruby-generation branch August 14, 2023 06:18
This was referenced Aug 18, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baywet @andrueastman