Fix for Enum collections types described as string collections #1846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1845
It fixes a bug where a property that is a collection of an Enum would be incorrectly evaluated to the
string
type in the CodeDom.This led to some missing models (as the enum would potentially not be referenced) as well as models having the
List<string>
leading to loss of the strongly typed enum.In summary the changes include: -
CreateCollectionModelDeclaration
to check if the schema contains anEnum
to allow theCreateModelDeclarations
method to do its job.Generation changes can be viewed at the links below.