Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aligns request body and response schema election #1602

Merged
merged 7 commits into from
Jun 2, 2022

Conversation

baywet
Copy link
Member

@baywet baywet commented May 30, 2022

fixes #134
no generation diff with our metadata

baywet added 5 commits May 30, 2022 15:09
- refactors default values managements

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet added the generator Issues or improvements relater to generation capabilities. label May 30, 2022
@baywet baywet self-assigned this May 30, 2022
baywet added 2 commits May 31, 2022 10:07
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet marked this pull request as ready for review May 31, 2022 14:09
@baywet baywet enabled auto-merge May 31, 2022 14:10
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

89.6% 89.6% Coverage
0.0% 0.0% Duplication

@@ -131,8 +131,8 @@ public void AddPathQueryOrHeaderParameter(params CodeParameter[] parameters)
public bool IsAccessor {
get => IsOfKind(CodeMethodKind.Getter, CodeMethodKind.Setter);
}
public List<string> SerializerModules { get; set; }
public List<string> DeserializerModules { get; set; }
public HashSet<string> SerializerModules { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@baywet baywet merged commit 5b00886 into main Jun 2, 2022
@baywet baywet deleted the feature/request-unknown-types branch June 2, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generator Issues or improvements relater to generation capabilities.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for requests that allow passing a model or a stream.
2 participants