Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composed types (De)serialization support. #6

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Composed types (De)serialization support. #6

merged 2 commits into from
Jan 26, 2023

Conversation

SilasKenneth
Copy link
Member

No description provided.

@SilasKenneth SilasKenneth self-assigned this Jan 24, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SilasKenneth SilasKenneth mentioned this pull request Jan 25, 2023
Merged
@SilasKenneth SilasKenneth linked an issue Jan 25, 2023 that may be closed by this pull request
composed types serialization support for PHP microsoft/kiota#1814
Closed
Ndiritu
Ndiritu approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@Ndiritu Ndiritu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests for union types and intersection types would be nice

@SilasKenneth SilasKenneth merged commit e268e68 into dev Jan 26, 2023
@SilasKenneth SilasKenneth deleted the feat/composed-types-deserialization branch January 26, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ndiritu Ndiritu Ndiritu approved these changes

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@zengin zengin Awaiting requested review from zengin

@shemogumbe shemogumbe Awaiting requested review from shemogumbe

Assignees

@SilasKenneth SilasKenneth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

composed types serialization support for PHP
2 participants
@SilasKenneth @Ndiritu