Feat/auth handler #1562
Draft
Feat/auth handler #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested changes
Sep 11, 2024
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| public class ContinuousAccessEvaluationClaims { |
There was a problem hiding this comment.
could we restrict this to package instead?
| import java.util.Objects; | ||
| import java.util.Set; | ||
|
|
||
| public class AuthorizationHandler implements Interceptor { |
...ents/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/AuthorizationHandler.java
Outdated
Show resolved
Hide resolved
...ents/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/AuthorizationHandler.java
Outdated
Show resolved
Hide resolved
...ents/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/AuthorizationHandler.java
Outdated
Show resolved
Hide resolved
...ents/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/AuthorizationHandler.java
Show resolved
Hide resolved
...ents/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/AuthorizationHandler.java
Outdated
Show resolved
Hide resolved
...ents/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/AuthorizationHandler.java
Outdated
Show resolved
Hide resolved
| @Nullable Map<String, Object> additionalAuthenticationContext, | ||
| @Nonnull Span span) { | ||
| final RequestInformation requestInformation = getRequestInformation(request); | ||
| authenticationProvider.authenticateRequest( |
There was a problem hiding this comment.
this should get the access token provider from the base authentication provider instead so we don't have to create an intermediate request information object.
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes microsoftgraph/msgraph-sdk-java#2096