Default context deadline to client timeout #71
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change syncronizes the deafult context deadline and the client Timeout. When a user does not pass a context deadline, the default fallback will not be the value of the client timeout. This should also make it possible to modify default context deadlines for a single point addressing #70
Should also prevent the client timeout overriding the context timeout when its significantly lower microsoftgraph/msgraph-sdk-go#302 (comment)
To modify a deadline, you can pass initialize
NetHttpRequestAdapter
with a modifiedclient.Timeout
property.