Allow custom response handlers to return nil result values #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintain consistent behavior with the default handler by returning nil for HTTP responses with a status code of 204 or empty body.
andrueastman
reviewed
May 9, 2024
There was a problem hiding this comment.
Thanks for contribution here @zhangyangjing
Any chance you can also add a changelog entry in the file at the root of the repository with a minor version bump?
baywet
requested changes
May 9, 2024
baywet
approved these changes
May 9, 2024
|
@zhangyangjing can you sign the CLA please? (see the bot comment) |
|
@microsoft-github-policy-service agree |
baywet
added a commit
that referenced
this pull request
May 9, 2024
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintain consistent behavior with the default handler by returning nil for HTTP responses with a status code of 204 or empty body.