Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed response body inspection #504

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Fixed response body inspection #504

merged 4 commits into from
Jan 7, 2025

Conversation

andrueastman
Copy link
Member

Fixes #501

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@andrueastman andrueastman marked this pull request as ready for review January 7, 2025 09:19
@andrueastman andrueastman requested a review from a team as a code owner January 7, 2025 09:19
@andrueastman andrueastman enabled auto-merge January 7, 2025 09:19
@andrueastman andrueastman mentioned this pull request Jan 7, 2025
Closed
Ndiritu
Ndiritu approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@Ndiritu Ndiritu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the tests, might it be better to mock the response via a handler?

@andrueastman andrueastman merged commit 9886fcc into main Jan 7, 2025
12 checks passed
@andrueastman andrueastman deleted the andrueastman/fixContentReading branch January 7, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ndiritu Ndiritu Ndiritu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InspectResponseBody stream consumed
2 participants
@andrueastman @Ndiritu