Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ext. methods to replace LINQ in generated code #253

Merged
merged 12 commits into from
Jun 13, 2024
Merged

Add ext. methods to replace LINQ in generated code #253

merged 12 commits into from
Jun 13, 2024

Conversation

kasperk81
Copy link
Contributor

@kasperk81 kasperk81 requested a review from a team as a code owner June 12, 2024 06:38
baywet
baywet requested changes Jun 12, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this. A couple of comments.

  • Version bump
  • Changelog entry
  • Unit tests

src/extensions/IEnumerableExtensions.cs Outdated Show resolved Hide resolved
src/extensions/IEnumerableExtensions.cs Show resolved Hide resolved
src/extensions/IEnumerableExtensions.cs Show resolved Hide resolved
baywet
baywet approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! @andrueastman for final review and merge

andrueastman
andrueastman approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@andrueastman andrueastman merged commit 2bbc677 into microsoft:main Jun 13, 2024
7 checks passed
@kasperk81 kasperk81 deleted the patch-1 branch June 13, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kasperk81 @andrueastman @baywet