Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(authentication): improve Validator #141

Merged
merged 6 commits into from
Jan 19, 2024
Merged

feat(authentication): improve Validator #141

merged 6 commits into from
Jan 19, 2024

Conversation

XdpCs
Copy link
Contributor

@XdpCs XdpCs commented Jan 18, 2024 •
edited
Loading

The input contains http or https which function will return an error. #130

@XdpCs
feat(authentication): improve Validator
47d9018 
improve Validator, if input contains http or https which function will return error.
andrueastman
andrueastman previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @XdpCs

Ping @rkodev for final review and merge

baywet
baywet requested changes Jan 19, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, a couple of remarks

authentication/allowed_hosts_validator.go Outdated Show resolved Hide resolved
authentication/allowed_hosts_validator.go Outdated Show resolved Hide resolved
baywet
baywet approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. Over to @rkodev

@baywet
Copy link
Member

baywet commented Jan 19, 2024

Also @XdpCs can you PR this to use the new method once this change is published? https://github.com/microsoft/kiota-authentication-azure-go/blob/61548a84bb5e0d4ae2edaa79416dc218f33ee240/azure_identity_access_token_provider.go#L62

@XdpCs
Copy link
Contributor Author

XdpCs commented Jan 19, 2024

Also @XdpCs can you PR this to use the new method once this change is published? https://github.com/microsoft/kiota-authentication-azure-go/blob/61548a84bb5e0d4ae2edaa79416dc218f33ee240/azure_identity_access_token_provider.go#L62

It's my pleasure.

@baywet baywet linked an issue Jan 19, 2024 that may be closed by this pull request
strip https:// prefix if present in allowed host value #130
Closed
@baywet baywet merged commit 58521b8 into microsoft:main Jan 19, 2024
7 checks passed
@XdpCs XdpCs deleted the fix-http-error branch January 19, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman andrueastman left review comments

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@rkodev rkodev Awaiting requested review from rkodev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

strip https:// prefix if present in allowed host value
3 participants
@XdpCs @baywet @andrueastman