Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checks whether an entry is already present before adding it #103

Merged
merged 3 commits into from
Sep 7, 2023
Merged

checks whether an entry is already present before adding it #103

merged 3 commits into from
Sep 7, 2023

Conversation

yseto
Copy link
Contributor

@yseto yseto commented Sep 6, 2023

fix #95

@yseto yseto mentioned this pull request Sep 6, 2023
Closed
baywet
baywet approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I made a couple of changes. The only thing that's left before we can merge this is the license agreement (see the bot's comment)

@yseto
Copy link
Contributor Author

yseto commented Sep 7, 2023

@microsoft-github-policy-service agree

@baywet baywet enabled auto-merge September 7, 2023 12:20
@baywet baywet merged commit 625c214 into microsoft:main Sep 7, 2023
@yseto yseto deleted the added-check branch September 8, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman Awaiting requested review from andrueastman

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@rkodev rkodev Awaiting requested review from rkodev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fatal error: concurrent map read and map write
2 participants
@yseto @baywet