Merge pull request #136 from XdpCs/fix-query-string

fix(request_information): fix empty string
microsoft · Jan 16, 2024 · 8266e41 · 8266e41
2 parents f119d9a + aa16daa
commit 8266e41
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+## [1.5.4] - 2024-01-16
+
+### Changed
+
+- Fix bug where empty string query parameters are added to the request. [#133](https://github.com/microsoft/kiota-abstractions-go/issues/133)
+
 ## [1.5.3] - 2023-11-24
 
 ### Added

diff --git a/request_information.go b/request_information.go
@@ -496,7 +496,7 @@ func (request *RequestInformation) AddQueryParameters(source any) {
 			continue
 		}
 		str, ok := value.(*string)
-		if ok && str != nil && *str != "" {
+		if ok && str != nil {
 			request.QueryParameters[fieldName] = *str
 		}
 		bl, ok := value.(*bool)

diff --git a/request_information_test.go b/request_information_test.go
@@ -150,7 +150,7 @@ func TestItDoesNotSetEmptySearchQueryParameters(t *testing.T) {
 	})
 	resultUri, err := requestInformation.GetUri()
 	assert.Nil(t, err)
-	assert.Equal(t, "http://localhost/me", resultUri.String())
+	assert.Equal(t, "http://localhost/me?%24search=", resultUri.String())
 }
 
 func TestItSetsPathParametersOfDateTimeOffsetType(t *testing.T) {