Specify the grammar formulations for attributes #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not exhaustively express all the places C++ attributes are valid, but it should cover enough detail to be useful. Fixes microsoft#63.
bogner
approved these changes
Jun 26, 2023
| all shared grammar elements between HLSL and C++. This spec attempts to detail | ||
| some of the grammar and parsing implications and will specify the process by | ||
| which existing attributes will convert to C++ attributes. | ||
| ### Attribute Parsing |
There was a problem hiding this comment.
Best to add a blank line before the section header for the benefit of those reading the markdown directly (I don't think it makes a difference in the rendered doc)
| which existing attributes will convert to C++ attributes. | ||
| ### Attribute Parsing | ||
|
|
||
| This proposal introduces new grammar formulations for parsing attributes |
There was a problem hiding this comment.
I'd probably drop the word "new" - "introduces grammar formulations" is clear
| ``` | ||
|
|
||
| In contrast to existing HLSL annotations and Microsoft-style attributes, these | ||
| attribute identifiers are case-sensitive `identifier` tokens. |
There was a problem hiding this comment.
This is probably clear enough from context and I'm just being pedantic, but "attribute identifiers are case-sensitive identifier tokens" isn't strictly true (there's also the attribute-scoped-token formulation).
Maybe:
In contrast to existing HLSL annotations and Microsoft-style attributes, these formulations use case-sensitive
identifiertokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not exhaustively express all the places C++ attributes are valid, but it should cover enough detail to be useful.
Fixes #63.