Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify aliasing and address space for vk::BufferPointer #53

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Specify aliasing and address space for vk::BufferPointer #53

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
676bb9b
Specify aliasing and address space for vk::BufferPointer
greg-lunarg May 5, 2023
d88d8c1
Refer to C99 for definition of restrict pointer.
greg-lunarg Jul 14, 2023
b83353b
Explicitly specify buffer pointers point into host memory address space.
greg-lunarg Sep 1, 2023
acc1edb
Merge branch 'main' into bp4
greg-lunarg Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions proposals/0010-vk-buffer-ref.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,16 @@ A vk::BufferPointer can otherwise be used whereever the HLSL spec does not other

Applying HLSL semantic annotations to objects of type vk::BufferPointer is disallowed.

### Buffer Pointers and Aliasing

By default, buffer pointers are assumed to be restrict pointers as defined by the C99 standard.

An attribute vk::aliased_pointer can be attached to a variable, function parameter or a block member of buffer pointer type. It is assumed that the pointee of an object with this attribute can overlap with the pointee of any other object with this attribute.

### Buffer Pointers and Address Space

All buffer pointers are presumed to point into the same address space. No new address space attributes are proposed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which address space? The default address space in HLSL is thread-local memory, which I assume isn't where these are expected to refer. I assume these are host memory, so we should state that explicitly.

Copy link
Contributor Author

@greg-lunarg greg-lunarg Sep 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. @llvm-beanz PTAL


## SPIR-V Appendices

### Appendix A: SPIR-V for RawBufferLoad
Expand Down