Fix some inconsistencies in the language #332
Labels
enhancement
New feature or request
Milestone
Comments
|
Thank you for the useful feedback! Setting this to HLSL backlog - this is something that is worthy of addressing at some point in the future but isn't an immediate priority for us. |
damyanp
pushed a commit
to damyanp/hlsl-specs
that referenced
this issue
Oct 10, 2024
The sample uses an invalid syntax for initializing a vk::BufferPointer. This fixes up the syntax. Fixes microsoft#332.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some of the newer additions to HLSL do not follow the existing conventions of the language and this creates some inconsistencies. It would have been great if some of these inconsistencies are fixed in some of the future HLSL versions.
The 1st is the
DispatchRaysIndex(). Someone would expect a sematic likeSV_DispatchRaysIndex. Same forPrimitiveIndex(),InstanceID()and probably more that I have forgotten.I haven't found exactly why that is but it seems that
SV_RayPayloadandSV_IntersectionAttributescan be omitted. Maybe they shouldn't since this creates confusion.Mesh shaders output is defined by
vertices,primitivesandindiceskeywords. Egout vertices MeshPerVertOut verts[N], out primitives MeshPerPrimitiveOut primitives[M], out indices uint3 indices[M]. This is inconsistent with how ray payload is defined for example. Maybe these should be semantics.These are only a few examples. There are possibly more.
The text was updated successfully, but these errors were encountered: