tests: fix error assertion and container layer sha256 #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rego error messages are now returned base64 encoded, so direct error message assertions don't work and we need to decode the policy decision string first. One of the tests was missing this. Additionally alpine container has been updated and the layer digest has changed, so the policy used to check backward compat is now broken. Update it to have a valid digest. Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
fix-rego-cri-integration-tests
branch
from
a98efc9 to
3faf405
Compare
helsaawy
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rego error messages are now returned base64 encoded, so direct error message assertions don't work and we need to decode the policy decision string first. One of the tests was missing this.
Additionally alpine container has been updated and the layer digest has changed, so the policy used to check backward compat is now broken. Update it to have a valid digest.