chore: add NX patch to fix "implicitDependencies", rename workspaces #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
chore/nx-patch
branch
from
dc1230b to
343fc11
Compare
miroslavstastny
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds NX patch to workaround Unable to remove dependencies between projects as specified in the docs via
implicitDependenciesnrwl/nx#8322, patches are tracked in chore: Nx patches/issues #15Renames packages in workspace as @Hotell suggested. It's not a big problem, but adds confusion in Nx configs:
{ "implicitDependencies": ["react"] }vs.
{ "implicitDependencies": ["@griffel/react"] }