Update final nodes output #1247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ha2trinh
reviewed
Oct 3, 2024
graphrag/index/update/dataframes.py
Outdated
| The merged relationships. | ||
| old_nodes : pd.DataFrame | ||
| The old nodes. | ||
| community_count_threshold : int, optional |
There was a problem hiding this comment.
should we have some params to define the % of existing relationships vs new relationships (e.g. if a new node has 2 old neighbors and 10 new neighbors then we consider putting it in a new community, rather than an old community?
There was a problem hiding this comment.
At the time I'm doing simple majority, and not even fine tuning it haha. I totally agree that should be percentage and not an int. to be independent on the dataset size.
My plan is to further refine this value once we have community reports generated.
But, will address the change of converting to a percentage right now
andresmor-ms
approved these changes
Oct 3, 2024
ha2trinh
reviewed
Oct 4, 2024
| new_delta_nodes_df[["level", "title"]], on=["level", "title"], how="outer" | ||
| ) | ||
|
|
||
| # Count the communities for each (level, title) pair |
There was a problem hiding this comment.
maybe we remove all these logics for calculating community_counts too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update create_final_nodes
Related Issues
[Reference any related issues or tasks that this pull request addresses.]
Proposed Changes
[List the specific changes made in this pull request.]
Checklist
Additional Notes
[Add any additional notes or context that may be helpful for the reviewer(s).]