Initial code drop - migrating from internal repo to GitHub #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertos
requested review from
sbtron,
walbourn,
bghgary,
thmignon and
agrittmsft
added 2 commits
November 25, 2017 15:04
thmignon
reviewed
Nov 27, 2017
README.md
Outdated
| The current release includes code for: | ||
| - Packing PBR material textures using [DirectXTex](http://github.com/Microsoft/DirectXTex) for use with the [MSFT_packing_occlusionRoughnessMetallic](https://github.com/sbtron/glTF/tree/MSFT_lod/extensions/Vendor/MSFT_packing_occlusionRoughnessMetallic) extension. | ||
| - Compressing textures as BC3, BC5 and BC7 and generate mip maps using [DirectXTex](http://github.com/Microsoft/DirectXTex) for use with the [MSFT_texture_dds](https://github.com/sbtron/glTF/tree/MSFT_lod/extensions/Vendor/MSFT_texture_dds) extension. | ||
| - Merging multiple documents into a single document with levels of detail using the [MSFT_lod](https://github.com/sbtron/glTF/tree/MSFT_lod/extensions/Vendor/MSFT_lod) extension. |
There was a problem hiding this comment.
Can we replace document with glTF asset to avoid the glTF SDK wording: "Merging multiple glTF assets into a single asset with multiple levels of detail"
Sometimes it's the small things :)
…ain function focused on glTF toolkit usage
…m GLTF was failing.
… copied), bufferViews were sorted incorrectly GLTF test suite results: 133/143 (93%)
… because of alignment. Also calculate min/max when serializing the accessors.
…vert accessors during serialization
…he deprecated warning (C4996)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that it still requires Microsoft credentials to compile - the GLTF SDK and RapidJSON repos are being consumed from internal sources.